Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
Prunable
trait to the Workflow model, allowing a scheduled command to keep these tables size down. I have also added a new config value for how for how many days we should keep the Workflow models for when pruning.I am happy to change the config property name, and the default values to something more suitable if required.
In our application, we'll be running lots of Workflows, and because the the callbacks are serialised, we found we had to change the database column from a
text
to alongtext
to allow bigger workflows. Keeping these Venture workflow job without pruning will result in our database getting bigger and bigger. With Prunable we can help keep our database size down, as for our purposes, once it's been a week we no longer care about the workflow as these would've been processed by then.