[Junie]: feat: make client property in ApplicationTestBuilder mutable #4879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![jetbrains-junie[bot]](https://avatars.githubusercontent.com/in/1164761?s=60&v=4){kind=small}
A proposal was implemented to allow the `client` property in `ApplicationTestBuilder` to be mutable, enabling better configuration for tests in Ktor. The implementation is error-free, with all existing tests passing along with a new test confirming the functionality of the new configuration capability.
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
osipxd
requested changes
May 23, 2025
| @@ -36,7 +36,7 @@ public interface ClientProvider { | |||
| * | |||
| * @see [testApplication] | |||
| */ | |||
| public val client: HttpClient | |||
| public var client: HttpClient | |||
There was a problem hiding this comment.
Let's keep val here, but make it var in TestApplicationBuilder
Comment on lines
+35
to
+39
| // Create a new client | ||
| val configuredClient = createClient { } | ||
|
|
||
| // Set the new client as the default | ||
| client = configuredClient |
There was a problem hiding this comment.
Let's simplify this
Suggested change
| // Create a new client | |
| val configuredClient = createClient { } | |
| // Set the new client as the default | |
| client = configuredClient | |
| // Create a new client and set it as the default | |
| client = createClient { } |
| class ClientConfigurationTest { | ||
|
|
||
| @Test | ||
| fun testClientConfiguration() = testApplication { |
There was a problem hiding this comment.
We have TestApplicationTest. Move this test into it
|
@jetbrains-junie, after fixing the comments remember to run |
|
Hey, it’s Junie by JetBrains! I started processing your request 🚀 |
A documentation update was made to the `client` property in the `ClientProvider` interface, explicitly stating that it is mutable and can be configured. The implementation is error-free, the API documentation was successfully updated, and all tests regarding the functionality of the mutable `client` property passed.
e5l
requested changes
May 26, 2025
| class ClientConfigurationTest { | ||
|
|
||
| @Test | ||
| fun testClientConfiguration() = testApplication { |
|
❌ There is a running Junie process for this pull request. Please, wait until it would be finished or cancel the corresponding Junie action |
…-f8c9-4070-8aeb-afd347a1327d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Hey! This PR was made for you with Junie, the coding agent by JetBrains Early Access Preview
It's still learning, developing, and might make mistakes. Please make sure you review the changes before you accept them.
We’d love your feedback — join our Discord to share bugs, ideas: here.
📊 Junie Summary
A proposal was implemented to allow the
clientproperty inApplicationTestBuilderto be mutable, enabling better configuration for tests in Ktor. The implementation is error-free, with all existing tests passing along with a new test confirming the functionality of the new configuration capability.