Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors parameter and path variable names across multiple machine learning project configurations to improve clarity and consistency. The changes standardize how ONNX model paths and parameter files are referenced throughout the codebase.
- Replaces generic
param_pathanddata_pathvariables with more descriptivefile/parameteranddirectory/onnxnames - Adds comprehensive descriptions to all launch file arguments for better documentation
- Ensures consistent variable naming across all project configurations
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/yolox/launch/yolox.launch.xml | Updates argument names and adds descriptions for YOLOX launch configuration |
| projects/yolox/config/yolox.param.yaml | Updates ONNX path variable reference for YOLOX parameters |
| projects/rtmdet/launch/rtmdet.launch.xml | Updates argument names and adds descriptions for RTMDet launch configuration |
| projects/rtmdet/config/rtmdet.param.yaml | Updates ONNX path variable reference for RTMDet parameters |
| projects/rfdetr/launch/rfdetr.launch.xml | Updates argument names and adds descriptions for RFDETR launch configuration |
| projects/rfdetr/config/rfdetr.param.yaml | Updates ONNX path variable reference for RFDETR parameters |
| projects/pidnet/launch/pidnet.launch.xml | Updates argument names and adds descriptions for PIDNet launch configuration |
| projects/pidnet/config/pidnet.param.yaml | Updates ONNX path variable reference for PIDNet parameters |
| projects/panoptic_fpn/launch/panoptic_fpn.launch.xml | Updates argument names and adds descriptions for Panoptic FPN launch configuration |
| projects/panoptic_fpn/config/panoptic_fpn.param.yaml | Updates ONNX path variable reference for Panoptic FPN parameters |
| projects/mask2former/launch/mask2former.launch.xml | Updates argument names and adds descriptions for Mask2Former launch configuration |
| projects/mask2former/config/mask2former.param.yaml | Updates ONNX path variable reference for Mask2Former parameters |
| projects/instance_rtmdet/launch/instance_rtmdet.launch.xml | Updates argument names and adds descriptions for Instance RTMDet launch configuration |
| projects/instance_rtmdet/config/instance_rtmdet.param.yaml | Updates ONNX path variable reference for Instance RTMDet parameters |
| projects/detr/launch/detr.launch.xml | Updates argument names and adds descriptions for DETR launch configuration |
| projects/detr/config/detr.param.yaml | Updates ONNX path variable reference for DETR parameters |
| projects/deimv2/launch/deimv2.launch.xml | Updates argument names and adds descriptions for DEIMv2 launch configuration |
| projects/deimv2/config/deimv2.param.yaml | Updates ONNX path variable reference for DEIMv2 parameters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
b370cc2 to
05c6c14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the way ONNX model paths and parameter files are handled across multiple project configurations and launch files. The main goal is to standardize variable names and improve clarity by replacing generic path variables with more descriptive ones, and by adding helpful descriptions to launch arguments.
Key changes include:
data_pathwithdirectory/onnxfor specifying ONNX model directories in parameter files.file/parameteranddirectory/onnxargument names, along with adding descriptions for better readability and maintainability.The most important changes are:
Standardization of ONNX Model Path Variables:
$(var directory/onnx)instead of$(var data_path)to specify the ONNX model location, improving clarity and consistency for model directory references. [1] [2] [3] [4] [5] [6] [7] [8] [9]Refactoring and Documentation of Launch Arguments:
file/parameteranddirectory/onnxas argument names instead ofparam_pathanddata_path, and each argument is supplemented with a clear description, making the launch files more user-friendly and self-documenting. [1] [2] [3] [4] [5] [6] [7] [8] [9]Consistent Parameter Passing in Launch Files:
<param from=...>tags in launch files now reference$(var file/parameter)instead of the old variable, ensuring consistency in how parameter files are loaded. [1] [2] [3] [4] [5] [6] [7] [8] [9]Improved Argument Documentation:
use_raw,build_only,visualize) now include descriptions, making it easier for users to understand their purpose. [1] [2] [3] [4] [5] [6] [7] [8] [9]These changes collectively improve maintainability, readability, and usability of the configuration and launch files across all supported projects.
How was this PR tested?
Notes for reviewers
None.
Effects on system behavior
None.