fix: resolve compilation error for invalid constexpr in C++17#57
Merged
fix: resolve compilation error for invalid constexpr in C++17#57
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a compilation error in C++17 by updating the definition of constant arrays for valid precision and calibration types in the TensorRT utility header.
- Changed
constexprarrays fromstd::string_viewtostatic constarrays withstd::stringelements - Added the
<array>header include to supportstd::arrayusage - Maintained the same string values while ensuring C++17 compatibility
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
f101024 to
bd6b83b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a minor update to the
mmros/include/mmros/tensorrt/utility.hppheader file. The change adds the<array>header to the set of included libraries, likely to support usage ofstd::arrayin the file.<array>to the list of included headers inutility.hppto enable use of fixed-size arrays.How was this PR tested?
Confirm the building succeeded.
Notes for reviewers
None.
Effects on system behavior
None.