Skip to content

fix: resolve compilation error for invalid constexpr in C++17#57

Merged
ktro2828 merged 1 commit intomainfrom
fix/invalid-constexpr
Oct 2, 2025
Merged

fix: resolve compilation error for invalid constexpr in C++17#57
ktro2828 merged 1 commit intomainfrom
fix/invalid-constexpr

Conversation

@ktro2828
Copy link
Copy Markdown
Owner

@ktro2828 ktro2828 commented Oct 2, 2025

Description

This pull request introduces a minor update to the mmros/include/mmros/tensorrt/utility.hpp header file. The change adds the <array> header to the set of included libraries, likely to support usage of std::array in the file.

  • Added <array> to the list of included headers in utility.hpp to enable use of fixed-size arrays.

How was this PR tested?

Confirm the building succeeded.

Notes for reviewers

None.

Effects on system behavior

None.

Copilot AI review requested due to automatic review settings October 2, 2025 20:09
@ktro2828 ktro2828 linked an issue Oct 2, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes a compilation error in C++17 by updating the definition of constant arrays for valid precision and calibration types in the TensorRT utility header.

  • Changed constexpr arrays from std::string_view to static const arrays with std::string elements
  • Added the <array> header include to support std::array usage
  • Maintained the same string values while ensuring C++17 compatibility

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread mmros/include/mmros/tensorrt/utility.hpp Outdated
Comment thread mmros/include/mmros/tensorrt/utility.hpp Outdated
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@ktro2828 ktro2828 force-pushed the fix/invalid-constexpr branch from f101024 to bd6b83b Compare October 2, 2025 20:11
@ktro2828 ktro2828 merged commit 94832ac into main Oct 2, 2025
0 of 2 checks passed
@ktro2828 ktro2828 deleted the fix/invalid-constexpr branch October 2, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] compilation error with constexpr variable

2 participants