-
Notifications
You must be signed in to change notification settings - Fork 109
vmm: add QEMU kernel config and build script #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vmm: add QEMU kernel config and build script #219
Conversation
Summary of ChangesHello @KairusZhang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces foundational changes to support QEMU-based virtual machine management by providing a dedicated script to build a custom Linux kernel image ( Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a build script for a QEMU kernel and updates an example script. The new build script, vmm/scripts/kernel/qemu/build.sh, contains a critical issue with an invalid git URL and also misses the installation of necessary build dependencies, which will cause it to fail. I've provided suggestions to fix these issues and to improve the script's robustness and style. Additionally, a change in examples/run_example_container.sh disables AppArmor, and I've noted the security implications of this change.
|
@KairusZhang the DCO check is failing, could you fix it? |
Signed-off-by: kairuszhang <[email protected]>
5235ef3 to
efe79fc
Compare
Yes, I had resubmmit the commit with the signature for sha:5235ef3. |
|
This is the resubmission by #214 |
|
/lgtm |
KairusZhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
|
@gemini-code-assist thanks, addressed with custom profile. |
|
You're welcome, @KairusZhang! I'm glad to hear that the custom profile (referring to the |
|
@kevin-wangzefeng @HITweihailiuxu All Gemini feedback addressed and Outdated comments resolved. Ready to merge! PTAL |
KairusZhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok,finished it
kevin-wangzefeng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Signed-off-by: kairuszhang <[email protected]>
aabff64 to
03445fd
Compare
Add qemu kernel vmlinux.bin created build.sh file.