Skip to content

Conversation

@Tweakzx
Copy link
Contributor

@Tweakzx Tweakzx commented Nov 18, 2025

add 3 scripts:

  1. install kuasar, cloud-hypervisor and other components on x86_64 machines
  2. build binaries of kuasar, containerd and virtiofsd, then install them and cloud-hypervisor for both x86_64 and aarch64 machines
  3. uninstall kuasar and its relative components

@Tweakzx Tweakzx requested a review from a team as a code owner November 18, 2025 07:57
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Tweakzx, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a comprehensive solution for managing the Kuasar VMM environment through two new shell scripts. The "install-kuasar-vmm.sh" script orchestrates the entire setup, from installing system dependencies to deploying Cloud-Hypervisor, Kuasar's VMM sandboxer, a specialized Containerd, crictl, and virtiofsd. Complementing this, the "uninstall-kuasar-vmm.sh" script provides a robust mechanism to cleanly remove these components and revert system configurations, enhancing the maintainability and ease of experimentation with Kuasar.

Highlights

  • Installation Script: A new "install-kuasar-vmm.sh" script is added to automate the setup of Kuasar VMM, including Cloud-Hypervisor, a custom Containerd, crictl, and virtiofsd.
  • Uninstallation Script: A corresponding "uninstall-kuasar-vmm.sh" script is introduced to safely remove all installed components and restore previous configurations for Containerd and crictl.
  • Configuration Backup: Both scripts incorporate logic to back up existing "/etc/containerd/config.toml" and "/etc/crictl.yaml" files before applying Kuasar-specific configurations, ensuring a clean rollback path.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces installation and uninstallation scripts for kuasar-vmm, which is a great step towards simplifying the user experience. My review focuses on improving the robustness, security, and cleanliness of these scripts. For the installation script, I've suggested using a temporary directory for downloads to ensure proper cleanup, adding checksum verification for security, quoting variables for robustness, and I've pointed out a brittle URL. For the uninstallation script, I've identified a missing file in the cleanup process, unused variables, and a misleading comment. Addressing these points will make the scripts more reliable and maintainable for users.

@Tweakzx Tweakzx force-pushed the install-scripts branch 5 times, most recently from 2f8379c to ff82db5 Compare November 21, 2025 02:30
@Tweakzx Tweakzx force-pushed the install-scripts branch 13 times, most recently from 64d0767 to f794124 Compare December 4, 2025 09:31
@hzxuzhonghu
Copy link

@Tweakzx Do you think we should also update readme or add a quickstart here https://kuasar.io/docs/

@Tweakzx
Copy link
Contributor Author

Tweakzx commented Dec 18, 2025

@Tweakzx Do you think we should also update readme or add a quickstart here https://kuasar.io/docs/

These three scipts only install/configure/remove kuasar-vmm with cloud-hypervisor, not all runtimes and backends that kuasar supports. Maybe it's still in the early stages and not suitable to be seen as a quickstart guide yet.

@hzxuzhonghu
Copy link

Otherwise It's a little bit hard to know how to run these script

@Tweakzx Tweakzx requested a review from a team as a code owner December 22, 2025 08:52
@Tweakzx
Copy link
Contributor Author

Tweakzx commented Dec 22, 2025

Otherwise It's a little bit hard to know how to run these script

@hzxuzhonghu added a README file to describe how to run these scripts

sudo ctr version
sudo crictl version
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After Post-Installation Steps, there should be a guide to use vmm. Can you link it to the existing guide

Copy link

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@kevin-wangzefeng kevin-wangzefeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kevin-wangzefeng
Copy link
Member

CI failue is irrelevant, manually merging.

@kevin-wangzefeng kevin-wangzefeng merged commit a5dc8e2 into kuasar-io:main Dec 25, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants