Skip to content

Conversation

@oglok
Copy link

@oglok oglok commented Dec 30, 2025

No description provided.

Signed-off-by: Ricardo Noriega De Soto <[email protected]>
@oglok oglok requested a review from a team as a code owner December 30, 2025 20:51
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @oglok, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the quality of the project's documentation by addressing a minor but important typo in the README.md file. The change ensures that the information presented is accurate and professional, enhancing readability for all users.

Highlights

  • Documentation Fix: Corrected a typo in the README.md file, changing "seperate" to "separate" within the "Runc Sandboxer" section.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a typo in the README.md file. However, the same sentence contains several other grammatical errors and could be phrased more clearly. I have provided a suggestion to improve the overall quality and readability of the documentation.

## Runc Sandboxer

Except secure containers, Kuasar also has provide the ability for [runC](https://github.com/opencontainers/runc) containers. In order to generate a seperate namespace, a slight process is created by the `runc-sandboxer` through double folked and then becomes the PID 1. Based on this namespace, the `runc-task` can create the container process and join the namespace. If the container need a private namespace, it will unshare a new namespace for itself.
Except secure containers, Kuasar also has provide the ability for [runC](https://github.com/opencontainers/runc) containers. In order to generate a separate namespace, a slight process is created by the `runc-sandboxer` through double folked and then becomes the PID 1. Based on this namespace, the `runc-task` can create the container process and join the namespace. If the container need a private namespace, it will unshare a new namespace for itself.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Thanks for fixing the typo! While you're at it, this paragraph contains a few other grammatical issues and could be phrased more clearly to improve readability. For instance:

  • Except secure containers could be rephrased to In addition to secure containers for better flow.
  • has provide is grammatically incorrect and should be provides.
  • a slight process is a bit ambiguous; a lightweight process would be more descriptive.
  • double folked should be a double fork or double forking.
  • container need should be container needs.

I've provided a suggestion that incorporates these fixes for a more polished and understandable description.

Suggested change
Except secure containers, Kuasar also has provide the ability for [runC](https://github.com/opencontainers/runc) containers. In order to generate a separate namespace, a slight process is created by the `runc-sandboxer` through double folked and then becomes the PID 1. Based on this namespace, the `runc-task` can create the container process and join the namespace. If the container need a private namespace, it will unshare a new namespace for itself.
In addition to secure containers, Kuasar also provides support for [runC](https://github.com/opencontainers/runc) containers. To generate a separate namespace, a lightweight process is created by the `runc-sandboxer` via a double fork, which then becomes PID 1. Based on this namespace, the `runc-task` can create the container process and join the namespace. If a container needs a private namespace, it will unshare a new namespace for itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant