-
Notifications
You must be signed in to change notification settings - Fork 109
Fix typos in documentation #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ricardo Noriega De Soto <[email protected]>
Summary of ChangesHello @oglok, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the quality of the project's documentation by addressing a minor but important typo in the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a typo in the README.md file. However, the same sentence contains several other grammatical errors and could be phrased more clearly. I have provided a suggestion to improve the overall quality and readability of the documentation.
| ## Runc Sandboxer | ||
|
|
||
| Except secure containers, Kuasar also has provide the ability for [runC](https://github.com/opencontainers/runc) containers. In order to generate a seperate namespace, a slight process is created by the `runc-sandboxer` through double folked and then becomes the PID 1. Based on this namespace, the `runc-task` can create the container process and join the namespace. If the container need a private namespace, it will unshare a new namespace for itself. | ||
| Except secure containers, Kuasar also has provide the ability for [runC](https://github.com/opencontainers/runc) containers. In order to generate a separate namespace, a slight process is created by the `runc-sandboxer` through double folked and then becomes the PID 1. Based on this namespace, the `runc-task` can create the container process and join the namespace. If the container need a private namespace, it will unshare a new namespace for itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the typo! While you're at it, this paragraph contains a few other grammatical issues and could be phrased more clearly to improve readability. For instance:
Except secure containerscould be rephrased toIn addition to secure containersfor better flow.has provideis grammatically incorrect and should beprovides.a slight processis a bit ambiguous;a lightweight processwould be more descriptive.double folkedshould bea double forkordouble forking.container needshould becontainer needs.
I've provided a suggestion that incorporates these fixes for a more polished and understandable description.
| Except secure containers, Kuasar also has provide the ability for [runC](https://github.com/opencontainers/runc) containers. In order to generate a separate namespace, a slight process is created by the `runc-sandboxer` through double folked and then becomes the PID 1. Based on this namespace, the `runc-task` can create the container process and join the namespace. If the container need a private namespace, it will unshare a new namespace for itself. | |
| In addition to secure containers, Kuasar also provides support for [runC](https://github.com/opencontainers/runc) containers. To generate a separate namespace, a lightweight process is created by the `runc-sandboxer` via a double fork, which then becomes PID 1. Based on this namespace, the `runc-task` can create the container process and join the namespace. If a container needs a private namespace, it will unshare a new namespace for itself. |
No description provided.