Port filtering refactor #27
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add comprehensive filter validation per Web Serial API specification: * Mutual exclusivity: Bluetooth and USB filters cannot be combined * USB dependency: usbProductId requires usbVendorId to be present * Empty filter prevention: at least one property must be specified - Add validation to requestPort() and listAvailablePorts() with TypeError rejection - Fix filter matching logic to handle undefined values correctly - Add documentation for Bluetooth service class ID limitation
- Fix bluetoothServiceClassId check to use !== undefined for consistency - Fix empty filter validation to only apply to USB filters, not Bluetooth - Prevent false positives when validating valid Bluetooth-only filters - Update error message to be more specific about USB filter requirements This fixes the critical flaw where Bluetooth-only filters would incorrectly trigger the empty filter validation, making the code fully compliant with the Web Serial API specification.
Owner
|
Looking good 👍
|
Author
|
Wow, that was some fast feedback! Thanks I'll do the changes. About the commit history, I remembered mid-project we should credit the original guy who created this, that's why It's a little messy. But that's a great catch, even if this gets squashed, I'll rebase them properly 🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This build upon #4.
I'm working in a project, which has an embedded system that runs strictly Firefox and we need to filter the devices, so I'm trying to finish the PR started by @RealTirex.
Still very much a work in progress.