refactor(e2e): add internal/fixture with the CR and tenancy builders

[vyncint]

Adds e2e/internal/fixture, builders for the CR literals the suites repeat. Nothing imports it yet, so no existing behaviour changes.

• Logging, FluentdSpec, Buffer, HTTPOutput and Flow, with functional options.
• LoggingInfra, LoggingTenant and LoggingRoute ported from common/helpers.go as pure builders returning the objects in creation order, so the caller creates them and the package needs no client, context or testing.T.
• Each default is the value most call sites already use. Anything that diverges passes an option.
• Tenancy keeps its own aggregator spec: it disables the PVC and requests less than the single-tenant suites.
• The package does not import common. The image constants are duplicated while both exist and a test pins them equal, so they cannot drift the way the syslog-ng reloader name did.

13 tests, no cluster. make check passes.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

e2e/internal/fixture/tenancy_test.go:78

• This assertion currently expects WatchNamespaces to be ["tenant"] even though the builder is called with nsTenant = "tenant-ns". If LoggingTenant is corrected to watch the passed tenant namespace, this expectation should match the argument value.

	lg := objs[2].(*v1beta1.Logging)
	require.Equal(t, TenantRef, lg.Spec.LoggingRef)
	require.Equal(t, "tenant-ns", lg.Spec.ControlNamespace)
	require.Equal(t, []string{TenantRef}, lg.Spec.WatchNamespaces)
}

e2e/internal/fixture/tenancy.go:125

• LoggingTenant takes nsTenant but hard-codes WatchNamespaces to TenantRef ("tenant"). If a suite uses a tenant namespace name other than "tenant", the tenant Logging will stop watching the namespace where the Flow/Output are created (it will watch "tenant" instead), breaking routing/aggregation.

		Spec: v1beta1.LoggingSpec{
			LoggingRef:       TenantRef,
			ControlNamespace: nsTenant,
			WatchNamespaces:  []string{TenantRef},
			FluentdSpec:      tenancyFluentdSpec(),

[vyncint]

Both suppressed comments on the last review were right. Fixed in 96b3131.

LoggingTenant took nsTenant but set WatchNamespaces to TenantRef, so the aggregator watched a namespace named after the loggingRef rather than the one its Flow and Output are created in. It came over that way from common/helpers.go:231, which hard-codes the literal "tenant". Both call sites — fluentbit-multitenant and fluentbit-hotreload — pass nsTenant := "tenant", so the two strings coincide there and the bug never fires. Nothing in common needs changing, and since the suites pass "tenant", the objects the builder produces for them are unchanged by this.

The second comment was the more useful half: the test passed "tenant-ns" and asserted []string{TenantRef}, so it pinned the trap rather than catching it. It now asserts against the Flow's own namespace, plus a guard that the fixture namespace differs from TenantRef — without that guard, anyone later aligning the two would silently make the assertion vacuous.

Both directions have a negative control:

• reverting the builder to TenantRef fails with expected ["tenant-ns"], actual ["tenant"]
• renaming the fixture namespace to "tenant" fails the guard with Should not be: "tenant"

make check passes, golangci-lint run --max-same-issues=0 --max-issues-per-linter=0 in e2e/ reports 0 issues, and the 13 tests still run in 0.01s with no cluster. All three commits build on their own.

[csatib02]

Please sweep the code and clean it up as much as you can, there is a lot of unnecessary commenting going on.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

e2e/internal/fixture/fixture_test.go:146

• This literal includes ObjectMeta.Namespace, but Logging is cluster-scoped. Keeping a namespace here makes the struct-equality safety net assert an invalid object shape (and would fail against a corrected Logging() builder).

	want := &v1beta1.Logging{
		ObjectMeta: metav1.ObjectMeta{
			Name:      "fluentd-aggregator-multiworker-test",
			Namespace: ns,
		},
		Spec: v1beta1.LoggingSpec{

e2e/internal/fixture/fixture_test.go:60

• Logging() should not populate .Namespace (Logging is cluster-scoped), so this assertion bakes in an invalid shape and will start failing once Logging() is fixed to match the CRD scope.

This issue also appears on line 141 of the same file.

func TestLoggingDefaults(t *testing.T) {
	l := Logging("ns", "lg")

	require.Equal(t, "lg", l.Name)
	require.Equal(t, "ns", l.Namespace)
	require.Equal(t, "ns", l.Spec.ControlNamespace)
	require.True(t, l.Spec.EnableRecreateWorkloadOnImmutableFieldChange)

[csatib02]

Seems like the ci is failing :/