Metadata trait should return guaranteed Metadata#47
Draft
clux wants to merge 1 commit into
Draft
Conversation
we know if it's there or not. Signed-off-by: clux <sszynrae@gmail.com>
Member
|
My feeling is that this +optional is very much not (2015 is very early), and it is best to default the ObjectMeta to an empty content, then to introduce a breaking change in traits of kube-rs. Unrelated discussion, taken out of context upstream revolve around that “metadata is not enough” (meaning they need a superset of it, not something else). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we know if it's there or not.
oversight from last release. upstream also does not do this.
That said, it is possible that we need to do a default deserialize if it ever is missing though.. we kind of do that some places in kube, but only for ListMeta: https://github.com/kube-rs/kube/blob/a6060c47e28dc82355efafa7f00e547fad4038a0/kube-core/src/object.rs#L25-L26
It'd be a bit annoying to not know if
.medataexists, but it's technically +optional in the schemas: Pod or newer Eviction...Going to try to NOT do this first.