Ensure watch_object handles objects removed before init#1577
Merged
Conversation
markdingram
force-pushed
the
watch_object
branch
2 times, most recently
from
e97bc20 to
83d81ba
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1577 +/- ##
=======================================
+ Coverage 75.3% 75.3% +0.1%
=======================================
Files 82 82
Lines 7323 7331 +8
=======================================
+ Hits 5511 5519 +8
Misses 1812 1812
|
clux
reviewed
Sep 12, 2024
Member
clux
left a comment
clux
left a comment
There was a problem hiding this comment.
Thanks for this. I think this makes sense. A couple of quick questions to make sure i understand properly.
…t isn't in any initial list fixes kube-rs#1576 Signed-off-by: Mark Ingram <mark@lincs.dev>
markdingram
force-pushed
the
watch_object
branch
from
83d81ba to
22abc45
Compare
…t isn't in any initial list - added a comment - resolved a nightly clippy - use a match guard instead of an nested if Signed-off-by: Mark Ingram <mark@lincs.dev>
markdingram
force-pushed
the
watch_object
branch
from
22abc45 to
b49ab8c
Compare
clux
changed the title
watch_object will include an item when the objec…watch_object handles objects removed before init
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stream produced by
watch_objectwill include an item when the object isn't in any initial listfixes #1576
Motivation
Solution
No tests! I see there are attempts already in this area underway, e.g. #1529
I would be happy to add tests if/when those tests land