Clippy fixes 2026 q1#1881
Merged
Merged
Conversation
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1881 +/- ##
=======================================
- Coverage 75.9% 75.9% -0.0%
=======================================
Files 85 85
Lines 8237 8237
=======================================
- Hits 6248 6247 -1
- Misses 1989 1990 +1
🚀 New features to boost your workflow:
|
hugoponthieu
pushed a commit
to hugoponthieu/kube
that referenced
this pull request
Jan 29, 2026
* clippy fix portforward manual multiple_of 2 Signed-off-by: clux <sszynrae@gmail.com> * allow large error enums for now Signed-off-by: clux <sszynrae@gmail.com> --------- Signed-off-by: clux <sszynrae@gmail.com>
cchndl
pushed a commit
to cchndl/kube
that referenced
this pull request
Feb 19, 2026
* clippy fix portforward manual multiple_of 2 Signed-off-by: clux <sszynrae@gmail.com> * allow large error enums for now Signed-off-by: clux <sszynrae@gmail.com> --------- Signed-off-by: clux <sszynrae@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes CI green without changing anything.
Generated fix via clippy + an
#[allow]directive.I think the large enum variants in errors could be worth looking at in the long run, there is an alternate in #1880 but it might be a breaking change, and not super keen on that.