Skip to content

Clippy fixes 2026 q1#1881

Merged
clux merged 2 commits into
mainfrom
clippy-fixes-2026-q1
Jan 2, 2026
Merged

Clippy fixes 2026 q1#1881
clux merged 2 commits into
mainfrom
clippy-fixes-2026-q1

Conversation

@clux
Copy link
Copy Markdown
Member

@clux clux commented Jan 2, 2026

Makes CI green without changing anything.

Generated fix via clippy + an #[allow] directive.

I think the large enum variants in errors could be worth looking at in the long run, there is an alternate in #1880 but it might be a breaking change, and not super keen on that.

clux added 2 commits January 2, 2026 08:13
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux linked an issue Jan 2, 2026 that may be closed by this pull request
@clux clux added the changelog-exclude changelog excluded prs label Jan 2, 2026
@clux clux marked this pull request as ready for review January 2, 2026 08:28
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 2, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.9%. Comparing base (abd316b) to head (11b924d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kube-client/src/api/portforward.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1881     +/-   ##
=======================================
- Coverage   75.9%   75.9%   -0.0%     
=======================================
  Files         85      85             
  Lines       8237    8237             
=======================================
- Hits        6248    6247      -1     
- Misses      1989    1990      +1     
Files with missing lines Coverage Δ
kube-runtime/src/controller/mod.rs 31.6% <ø> (ø)
kube-client/src/api/portforward.rs 0.0% <0.0%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clux clux merged commit 14b5010 into main Jan 2, 2026
17 checks passed
@clux clux deleted the clippy-fixes-2026-q1 branch January 2, 2026 08:31
hugoponthieu pushed a commit to hugoponthieu/kube that referenced this pull request Jan 29, 2026
* clippy fix portforward manual multiple_of 2

Signed-off-by: clux <sszynrae@gmail.com>

* allow large error enums for now

Signed-off-by: clux <sszynrae@gmail.com>

---------

Signed-off-by: clux <sszynrae@gmail.com>
cchndl pushed a commit to cchndl/kube that referenced this pull request Feb 19, 2026
* clippy fix portforward manual multiple_of 2

Signed-off-by: clux <sszynrae@gmail.com>

* allow large error enums for now

Signed-off-by: clux <sszynrae@gmail.com>

---------

Signed-off-by: clux <sszynrae@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-exclude changelog excluded prs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clippy nightly fails with result_large_err on controller::Error

1 participant