Skip to content

features: making client tracing opt-in#1972

Merged
clux merged 1 commit into
kube-rs:mainfrom
mattklein123:tracing
May 4, 2026
Merged

features: making client tracing opt-in#1972
clux merged 1 commit into
kube-rs:mainfrom
mattklein123:tracing

Conversation

@mattklein123
Copy link
Copy Markdown
Contributor

Due to tokio-rs/tracing#3521 I would like to request that this feature be opt-in.

Due to tokio-rs/tracing#3521 I would like to
request that this feature be opt-in.

Signed-off-by: Matt Klein <mklein@bitdrift.io>
@mattklein123
Copy link
Copy Markdown
Contributor Author

Let me know if you want it to default on and I can figure that out but I would like some way of turning off tracing on hyper-util. Thank you.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.5%. Comparing base (796b90d) to head (e883f2a).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1972     +/-   ##
=======================================
+ Coverage   76.5%   76.5%   +0.1%     
=======================================
  Files         89      89             
  Lines       8587    8590      +3     
=======================================
+ Hits        6563    6568      +5     
+ Misses      2024    2022      -2     

see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clux
Copy link
Copy Markdown
Member

clux commented Apr 22, 2026

Hey, thanks for raising this. From upstream comments it makes sense to have it as opt-in until direction/consensus is more clear.

Obviously not super happy about having an extra feature for a workaround, but I guess it could be removed in the future if there's a better solution upstream. Waiting a week to see if there are other opinions, otherwise will probably ship this in 4.0.

@clux clux added the changelog-change changelog change category for prs label Apr 22, 2026
@clux clux added this to the 4.0.0 milestone Apr 22, 2026
@clux clux merged commit 26a42f2 into kube-rs:main May 4, 2026
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-change changelog change category for prs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants