features: making client tracing opt-in#1972
Merged
Merged
Conversation
Due to tokio-rs/tracing#3521 I would like to request that this feature be opt-in. Signed-off-by: Matt Klein <mklein@bitdrift.io>
Contributor
Author
|
Let me know if you want it to default on and I can figure that out but I would like some way of turning off tracing on hyper-util. Thank you. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1972 +/- ##
=======================================
+ Coverage 76.5% 76.5% +0.1%
=======================================
Files 89 89
Lines 8587 8590 +3
=======================================
+ Hits 6563 6568 +5
+ Misses 2024 2022 -2 🚀 New features to boost your workflow:
|
Member
|
Hey, thanks for raising this. From upstream comments it makes sense to have it as opt-in until direction/consensus is more clear. Obviously not super happy about having an extra feature for a workaround, but I guess it could be removed in the future if there's a better solution upstream. Waiting a week to see if there are other opinions, otherwise will probably ship this in 4.0. |
clux
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to tokio-rs/tracing#3521 I would like to request that this feature be opt-in.