Conversation
Signed-off-by: John Vandenberg <jayvdb@gmail.com>
Signed-off-by: John Vandenberg <jayvdb@gmail.com>
Signed-off-by: Eirik A <sszynrae@gmail.com>
Signed-off-by: Eirik A <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1975 +/- ##
=======================================
+ Coverage 76.5% 76.5% +0.1%
=======================================
Files 89 89
Lines 8590 8585 -5
=======================================
- Hits 6564 6563 -1
+ Misses 2026 2022 -4
🚀 New features to boost your workflow:
|
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Danil-Grigorev
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
carrying on from #1848
serde-saphyr::Errorto avoid clippy warningsThe one new error (for when we have an invalid kubeconfig) now looks better. Here's some saphyr output when i added a dash too many.
cargo run --example=kubectl get deployment -A Compiling kube-client v3.1.0 (/home/clux/kube/kube/kube-client) Compiling kube-runtime v3.1.0 (/home/clux/kube/kube/kube-runtime) Compiling kube v3.1.0 (/home/clux/kube/kube/kube) Compiling kube-examples v3.1.0 (/home/clux/kube/kube/examples) Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.41s Running `/home/clux/kube/kube/target/debug/examples/kubectl get deployment -A` Error: failed to parse kubeconfig YAML: error: line 3 column 3: unexpected event: expected mapping start --> <input>:3:3 | 1 | apiVersion: v1 2 | clusters: 3 | - - cluster: | ^ unexpected event: expected mapping start 4 | certificate-authority-data: X… |