Skip to content

chore: improve kube maintenance path#1988

Open
oab24413gmai wants to merge 1 commit into
kube-rs:mainfrom
oab24413gmai:maint/20260524202718
Open

chore: improve kube maintenance path#1988
oab24413gmai wants to merge 1 commit into
kube-rs:mainfrom
oab24413gmai:maint/20260524202718

Conversation

@oab24413gmai
Copy link
Copy Markdown

Summary:

  • Add additional unit tests in kube-core/src/params.rs covering edge cases of the query-string serialization for ListParams/WatchParams/PatchParams builders — e.g. behavior when label_selector/field_selector are empty strings, combining timeout + bookmarks, and verifying that resource_version='0' is preserved rather than dropped. Pure additive tests against existing public APIs, no behavioral change.
  • Keep the change narrow so it is straightforward to review.

Notes:

  • I kept this scoped to the relevant implementation and tests.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.8%. Comparing base (1f5a46b) to head (228759b).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1988     +/-   ##
=======================================
+ Coverage   76.7%   76.8%   +0.1%     
=======================================
  Files         89      89             
  Lines       8747    8792     +45     
=======================================
+ Hits        6703    6745     +42     
- Misses      2044    2047      +3     
Files with missing lines Coverage Δ
kube-core/src/params.rs 87.9% <100.0%> (+2.5%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, nicely scoped. Clear.

@clux clux added the changelog-exclude changelog excluded prs label May 24, 2026
@clux
Copy link
Copy Markdown
Member

clux commented May 24, 2026

Are you able to run just fmt and commit with --signoff?

@clux clux added this to the 4.0.0 milestone May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-exclude changelog excluded prs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants