Fix DHCP release bug #351
Merged
Fix DHCP release bug #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaocw2020
force-pushed
the
release-bug
branch
3 times, most recently
from
3129d87 to
4158d20
Compare
yaocw2020
force-pushed
the
release-bug
branch
from
4158d20 to
4bf0366
Compare
Collaborator
|
Awesome, waiting for the dependant PR at this time. |
thebsdbox
approved these changes
Apr 18, 2022
The macvlan interface could not be deleted until the DHCP client has released the IP. If the network manager in the operating system uses DHCP to obtain an IP for the network card, it will occupy the DHCP client port. In this case the release function will fail because the unicast connection with UDP socket need the same port. Update dhcp package and use a raw socket. Signed-off-by: yaocw2020 <[email protected]>
Contributor
Author
|
We replace the |
thebsdbox
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macvlan interface should not be deleted until the DHCP client has
released the IP.
If the network manager in the operating system uses DHCP to obtain an IP
for the network card, it will occupy the DHCP client port. In this case,
the release function will fail because the unicast connection with the UDP
socket needs the same port. The solution depends on the pr Change unicast connection of DHCPv4 client as a raw socket insomniacslk/dhcp#458
Related issue: harvester/harvester#1835
Signed-off-by: yaocw2020 [email protected]