fix(llm_simple_qa): replace hardcoded paths and fix basemodel compatibility#388
fix(llm_simple_qa): replace hardcoded paths and fix basemodel compatibility#388rakshaak29 wants to merge 4 commits intokubeedge:mainfrom
Conversation
|
Welcome @rakshaak29! It looks like this is your first PR to kubeedge/ianvs 🎉 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rakshaak29 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request updates configuration paths to relative links, adds local artifacts to .gitignore, and switches the base model to a public Hugging Face repository. Feedback identifies a regression in basemodel.py where CUDA support was removed from device detection, potentially causing runtime errors or performance degradation. Additionally, the new preprocess method returns None, which may break the data pipeline if subsequent stages expect processed data.
|
/assign @jaypume |
…ix basemodel - Replace all hardcoded absolute paths with relative paths in YAML configs - Use HuggingFace Hub model ID (Qwen/Qwen2.5-0.5B-Instruct) instead of local path - Add missing preprocess() method to BaseModel (required by sedna) - Add MPS/CPU device detection for macOS compatibility - Update .gitignore to exclude local dev artifacts Signed-off-by: rakshaak29 <rakshak29@gmail.com>
Signed-off-by: rakshaak29 <rakshak29@gmail.com>
Signed-off-by: rakshaak29 <rakshak29@gmail.com>
Signed-off-by: rakshaak29 <rakshak29@gmail.com>
e0566e3 to
b584a15
Compare
What this PR does
Fixes the
llm_simple_qaexample which was broken due to hardcoded paths and missing methods.Fixes #387
Changes
/home/icyfeather/...) with relative paths (./examples/...,./dataset/...,./workspace)Qwen/Qwen2.5-0.5B-Instruct) instead of local pathpreprocess()method required by sedna's SingleTaskLearning paradigmTesting
Verified the benchmark runs end-to-end successfully: