fix: update stale pedestrian_tracking paths to fix broken examples#392
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ARYANPATEL-BIT The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request updates various file paths and URLs across the pedestrian tracking example to align with a reorganized directory structure under examples/MOT17. The feedback suggests replacing hardcoded paths from the repository root with paths relative to the script's location in generate_reports.py and cmc.py to make the scripts more robust and independent of the execution directory.
examples/MOT17/multiedge_inference_bench/pedestrian_tracking/generate_reports.py
Outdated
Show resolved
Hide resolved
examples/MOT17/multiedge_inference_bench/pedestrian_tracking/testenv/reid/cmc.py
Outdated
Show resolved
Hide resolved
…nd code Signed-off-by: Aryan Patel <aryan.patel7291@gmail.com>
a2f35a4 to
3cf3b8c
Compare
|
/assign @MooreZheng |
What does this PR do?
This PR fixes a critical pathing issue in the MOT17 benchmark example that was preventing it from running. It appears the example directory was previously renamed from
pedestrian_trackingtoMOT17, but the internal file references within the.yamlconfigs and.pyfiles were never updated.This PR performs a global replacement of:
to:
across all affected configuration files and scripts.
Why is it needed?
Currently, running:
(or the
reid_job.yaml) fails immediately with aFileNotFoundError, because Ianvs attempts to resolve thetestenv, algorithm, and metric scripts at the old path.Resolving these paths restores the out‑of‑the‑box functionality of the MOT17 benchmarking examples, allowing both tracking and ReID jobs to run without path errors.
Changes proposed
Replaced the stale path
pedestrian_tracking/multiedge_inference_benchwithMOT17/multiedge_inference_bench/pedestrian_trackingin the following files:Configs
tracking_job.yamlreid_job.yamlAlgorithms
m3l_algorithm.yamlbyte_track_algorithm.yamlTest Environments
testenv/reid/testenv.yamltestenv/tracking/testenv.yamlPython Scripts
generate_reports.py(fixed hardcoded output directory path)testenv/reid/cmc.py(fixed hardcoded output directory path)Docs
README.md(updated example path in the report generation documentation)Testing done
pedestrian_trackingreferences relating to the old root path were replaced.FileNotFoundErrorwhen executed from the root directory.##Fixes: #391