Skip to content

[LFX Term 1 2026] Restoring LLM Edge Benchmark Suite Single Task Bench#408

Open
NishantSinghhhhh wants to merge 3 commits intokubeedge:mainfrom
NishantSinghhhhh:Restoration-llm-edge-benchmark
Open

[LFX Term 1 2026] Restoring LLM Edge Benchmark Suite Single Task Bench#408
NishantSinghhhhh wants to merge 3 commits intokubeedge:mainfrom
NishantSinghhhhh:Restoration-llm-edge-benchmark

Conversation

@NishantSinghhhhh
Copy link
Copy Markdown
Contributor

@NishantSinghhhhh NishantSinghhhhh commented Apr 23, 2026

What type of PR is this?
/kind bug
/kind feature

What this PR does / why we need it:
This PR restores and fixes the llm-edge-benchmark-suite (single_task_bench) so it successfully executes end-to-end within the current Ianvs SingleTaskLearning paradigm.

Previously, the LLM benchmarking pipeline was failing due to missing dependencies, pipeline contract mismatches (missing/strict method signatures), and inaccurate C++ stderr log parsing for latency metrics.

Key changes include:

  • Added Dependencies: Created a requirements.txt to explicitly include llama-cpp-python and other necessary inference packages.
  • Pipeline Contract Alignment: Added preprocess and postprocess methods to LlamaCppModel with optional arguments (data=None, **kwargs) to satisfy the strict signature checks of the Ianvs pipeline without throwing TypeError.

…el with optional arguments

Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
@kubeedge-bot kubeedge-bot added kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 23, 2026
@kubeedge-bot kubeedge-bot requested review from Poorunga and hsj576 April 23, 2026 13:30
@kubeedge-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NishantSinghhhhh
To complete the pull request process, please assign jaypume after the PR has been reviewed.
You can assign the PR to them by writing /assign @jaypume in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 23, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an LLM edge benchmark suite, adding a requirements file and implementing a base model class. The predict method was refactored to use streaming for measuring prefill latency, and dummy preprocess, postprocess, and train methods were added to satisfy pipeline requirements. A review comment suggests that the train method should return the model path from an instance variable rather than kwargs, as the latter may be empty during execution, leading to an incorrect return value.

Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
…quirements for LLM edge benchmark

Signed-off-by: NishantSinghhhhh <nishantsingh_230137@aitpune.edu.in>
@NishantSinghhhhh NishantSinghhhhh changed the title feat: add requirements for LLM edge benchmark and enhance LlamaCppMod… [LFX Term 1 2026] Restoring LLM Edge Benchmark Suite Single Task Bench Apr 23, 2026
@NishantSinghhhhh
Copy link
Copy Markdown
Contributor Author

@MooreZheng sir, I have added Readme for LLM Edge Benchmark Suite Single Task Bench, a Requirements.txt and minimal changes in the Basemodel.py to make it work,

Screencast.from.2026-04-23.18-52-16.webm

@NishantSinghhhhh
Copy link
Copy Markdown
Contributor Author

NishantSinghhhhh commented May 7, 2026

  1. Optional pre-Process and Post process
  2. Not changing the indentation
  3. no unnecessary comments
  4. Reasoning for prediction as 0

Copy link
Copy Markdown
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. try to make the preprocess optionable to save future burden
  2. check whether there is problem for the prediction fuction. If not, just leave it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants