Skip to content

Fix Accessibility Violations for Header Icon Links #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huangkevin-apr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Accessibility Violations for Header Icon Links #758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docusaurus.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,16 +178,19 @@ const config = {
href: "https://github.com/kubeedge/kubeedge",
position: "right",
className: "header-github-link heade-icon",
"aria-label": "GitHub repository", // Accessibility: Add aria-label for icon-only link
},
{
href: "https://twitter.com/KubeEdge",
position: "right",
className: "header-x-link heade-icon",
"aria-label": "KubeEdge Twitter", // Accessibility: Add aria-label for icon-only link
},
{
to: "/docs/community/slack",
position: "right",
className: "header-slack-link heade-icon",
"aria-label": "KubeEdge Slack community", // Accessibility: Add aria-label for icon-only link
Comment on lines +181 to +193
Copy link

@gemini-code-assist gemini-code-assist bot Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While adding aria-label is a great step for accessibility, these labels are hardcoded in English. Since the site supports internationalization (i18n) for English and Chinese, these labels should also be translated to provide an accessible experience for all users. Currently, a screen reader user on the Chinese version of the site will hear an English label for these links. Please consider making these labels translatable.

},
{
type: "localeDropdown",
Expand Down