fix: address a RO directory issue in templates#706
Merged
michaelawyu (michaelawyu) merged 2 commits intoMay 13, 2026
Merged
Conversation
Signed-off-by: michaelawyu <chenyu1@microsoft.com>
Signed-off-by: michaelawyu <chenyu1@microsoft.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
| # This path must match FleetWebhookCertDir in pkg/webhook/webhook.go | ||
| mountPath: /tmp/k8s-webhook-server/serving-certs | ||
| {{- if .Values.useCertManager }} | ||
| readOnly: true |
There was a problem hiding this comment.
I'm assuming since we certManager which generates certs in this flow we make this volume read only and when we don't since we clear the directory and write the certs, we can't have the readOnly field down below ?
Member
Author
There was a problem hiding this comment.
Yeah, it seems that the cause of this issue is that, with self-signed certs, we would always need write access. The readOnly field was set to false (the default) originally; the tricky part is about the mount path 😞
Arvind Thirumurugan (Arvindthiru)
approved these changes
May 13, 2026
michaelawyu (michaelawyu)
merged commit ce6b31d
into
kubefleet-dev:main
16 checks passed
Member
Author
|
Merging this to unblock progress -> if there's any concern, please let me know. |
michaelawyu (michaelawyu)
deleted the
fix/chart-err-with-improved-security-context
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR addresses an issue which will cause agent to fail upon startup when using self-signed certs with the newly improved security context setup.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
NA
Special notes for your reviewer
NA