Skip to content

Conversation

@ChenYi015
Copy link
Member

Purpose of this PR

Proposed changes:

  • Add docs for releasing arena
  • Add release version badge to README.md

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

@ChenYi015
Copy link
Member Author

/assign @cheyang

docs/release.md Outdated

## Update Changelog

Update the `CHANGELOG.md` file by running:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about how to handle the situation where, after releasing a new version, someone builds the arena version using the master branch and it turns out to be the same as the version built from the previous branch. How should this be addressed?

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Nov 18, 2024
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1cba9b9 into kubeflow:master Nov 18, 2024
4 checks passed
@ChenYi015 ChenYi015 deleted the docs/release branch December 10, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants