Skip to content

Conversation

@fy2462
Copy link

@fy2462 fy2462 commented Nov 10, 2025

The mpi job in arena master branch is v1alpha1, it is too old and can not submit to trainning operator V1
So, I update the mpi job charts and code to fix it.

What I do in code:

  1. update mpi job type and client apiVersion v1, and import them from training operator v1.
  2. update mpi job charts.
  3. remove mpi operator code in arena and upgrade vendor folder.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gujingit for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fy2462
Copy link
Author

fy2462 commented Nov 14, 2025

/cc @gujingit

@google-oss-prow google-oss-prow bot requested a review from gujingit November 14, 2025 13:45
@ChenYi015
Copy link
Member

Hi @fy2462 , I have removed the vendor directory in #1387 . Since the size of code changes is huge, could you do a rebase to make it easier to review?

@ChenYi015
Copy link
Member

Besides, you need to sign off your commits by git commit -s -m <message> to pass the DCO check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants