helm: synCHRONIZE kserve models web app chart#3481
Conversation
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
|
Welcome to the Kubeflow Manifests Repository Thanks for opening your first PR. Your contribution means a lot to the Kubeflow community. Before making more PRs: Community Resources:
Thanks again for helping to improve Kubeflow. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Helm chart for KServe Models Web App to a newer application release and extends permissions/resources used by the app.
Changes:
- Bump the default image tag and chart
appVersiontov0.18.0. - Extend ClusterRole permissions to include
trainedmodelsresources. - Adjust Istio VirtualService labels and remove trailing whitespace.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| experimental/helm/charts/kserve-models-web-app/values.yaml | Updates default image tag used by the chart. |
| experimental/helm/charts/kserve-models-web-app/Chart.yaml | Updates chart appVersion to match the new app release. |
| experimental/helm/charts/kserve-models-web-app/templates/rbac/clusterrole.yaml | Grants RBAC access to trainedmodels and trainedmodels/status. |
| experimental/helm/charts/kserve-models-web-app/templates/istio/virtualservice.yaml | Changes labels applied to the VirtualService resource. |
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
|
Thank you |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Template for Kubeflow Manifests
✏️ Summary of Changes
This PR syncs
experimental/helm/charts/kserve-models-web-appwith the Kustomize models web app update merged in #3477.It updates the Helm chart to render the current Kustomize shape:
ghcr.io/kserve/models-web-app:0.18.0trainedmodelsandtrainedmodels/statusRBAC resourcesThis fixes the current
Compare All Scenariosbaseline failure forkserve-models-web-app, which is blocking unrelated Helm chart PRs because the workflow runs all registered comparison scenarios.📦 Dependencies
Related to #3477.
This unblocks the shared Helm comparison workflow for unrelated Helm PRs such as #3478, #3479, and #3480.
🐛 Related Issues
Part of #3423.
✅ Contributor Checklist
Validation
All commands passed locally.