Skip to content

helm: synCHRONIZE kserve models web app chart#3481

Merged
google-oss-prow[bot] merged 2 commits into
kubeflow:masterfrom
danish9039:gsoc/kserve-models-web-app-v018-sync
May 25, 2026
Merged

helm: synCHRONIZE kserve models web app chart#3481
google-oss-prow[bot] merged 2 commits into
kubeflow:masterfrom
danish9039:gsoc/kserve-models-web-app-v018-sync

Conversation

@danish9039

Copy link
Copy Markdown
Member

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

This PR syncs experimental/helm/charts/kserve-models-web-app with the Kustomize models web app update merged in #3477.

It updates the Helm chart to render the current Kustomize shape:

  • ghcr.io/kserve/models-web-app:0.18.0
  • trainedmodels and trainedmodels/status RBAC resources
  • VirtualService labels aligned with the updated Kustomize component output

This fixes the current Compare All Scenarios baseline failure for kserve-models-web-app, which is blocking unrelated Helm chart PRs because the workflow runs all registered comparison scenarios.

📦 Dependencies

Related to #3477.

This unblocks the shared Helm comparison workflow for unrelated Helm PRs such as #3478, #3479, and #3480.

🐛 Related Issues

Part of #3423.

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

Validation

helm lint experimental/helm/charts/kserve-models-web-app
./tests/helm_kustomize_compare.sh kserve-models-web-app base
./tests/helm_kustomize_compare.sh kserve-models-web-app kubeflow
./tests/helm_kustomize_compare_all.sh
git diff --check

All commands passed locally.

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Copilot AI review requested due to automatic review settings May 25, 2026 13:29
@github-actions

Copy link
Copy Markdown

Welcome to the Kubeflow Manifests Repository

Thanks for opening your first PR. Your contribution means a lot to the Kubeflow community.

Before making more PRs:
Please ensure your PR follows our Contributing Guide.
Please also be aware that many components are synchronizes from upstream via the scripts in /scripts.
So in some cases you have to fix the problem in the upstream repositories first, but you can use a PR against kubeflow/manifests to test the platform integration.

Community Resources:

Thanks again for helping to improve Kubeflow.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the Helm chart for KServe Models Web App to a newer application release and extends permissions/resources used by the app.

Changes:

  • Bump the default image tag and chart appVersion to v0.18.0.
  • Extend ClusterRole permissions to include trainedmodels resources.
  • Adjust Istio VirtualService labels and remove trailing whitespace.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
experimental/helm/charts/kserve-models-web-app/values.yaml Updates default image tag used by the chart.
experimental/helm/charts/kserve-models-web-app/Chart.yaml Updates chart appVersion to match the new app release.
experimental/helm/charts/kserve-models-web-app/templates/rbac/clusterrole.yaml Grants RBAC access to trainedmodels and trainedmodels/status.
experimental/helm/charts/kserve-models-web-app/templates/istio/virtualservice.yaml Changes labels applied to the VirtualService resource.

Comment thread experimental/helm/charts/kserve-models-web-app/Chart.yaml Outdated
@danish9039 danish9039 marked this pull request as ready for review May 25, 2026 13:32
@google-oss-prow google-oss-prow Bot requested a review from kimwnasptd May 25, 2026 13:32
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@danish9039

Copy link
Copy Markdown
Member Author

@juliusvonkohout

@juliusvonkohout juliusvonkohout changed the title helm: sync kserve models web app chart helm: synCHRONIZE kserve models web app chart May 25, 2026
@juliusvonkohout

Copy link
Copy Markdown
Member

Thank you
/lgtm
/approve

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit f18b4fc into kubeflow:master May 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants