Skip to content

chore: revert legal disclaimer #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pboyd
Copy link
Member

@pboyd pboyd commented Feb 7, 2025

PR #816 did not have the intended effect, so it should be reverted.

See #818 for a better fix.

PR kubeflow#816 did not have the intended effect, so it should be reverted.

Signed-off-by: Paul Boyd <[email protected]>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign franciscojavierarceo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@varodrig
Copy link
Contributor

varodrig commented Feb 9, 2025

@pboyd agree that needs to be fixed and updated. but why to removed the source code instead of update it with the fix?
can you add more clarifications?

@pboyd
Copy link
Member Author

pboyd commented Feb 10, 2025

Hi @varodrig, thanks for the reply. The correct fix isn't in the code, so I can't submit a PR for it. The website URL in the repo metadata needs to point to www.kubeflow.org, I don't have access to update it myself, but there are more details in #818. It should only a take a second, if you have access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants