Skip to content

KEP 831-Kubeflow-Helm-Support: Support Helm as an Alternative for Kustomize #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from

Conversation

chasecadet
Copy link
Contributor

Proposal: Introduce Helm Chart for Basic Kubeflow Installation
Summary

This PR proposes introducing a Helm chart for deploying a basic Kubeflow installation. Given the increased demand and the KSC's stance in issue #821 on maintaining neutral deployment language and user-defined production readiness, supporting Helm will improve adoption and simplify deployments while preserving the flexibility of community-maintained manifests.
Background

There have been ongoing community efforts around Helm support, including discussions in the Kubeflow-Helm-Chart Slack channel. Formalizing this effort will provide users with an officially supported Helm chart that aligns with Kubeflow's deployment principles.

Next Steps

* Gather community feedback on the proposal.
* Discuss best practices for Helm chart structure and maintenance.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign franciscojavierarceo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chasecadet
Copy link
Contributor Author

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great effort @chasecadet and team!
I will take a look next week.
@chasecadet @akgraner Please can you also inform about this KEP in Kubeflow Discuss?

/hold for community to review.
cc @kubeflow/wg-training-leads @kubeflow/wg-automl-leads @kubeflow/wg-manifests-leads @kubeflow/wg-data-leads @kubeflow/release-team @kubeflow/wg-pipeline-leads @kubeflow/wg-notebooks-leads @kubeflow/wg-deployment-leads @kubeflow/kubeflow-steering-committee

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Mar 5, 2025

@chasecadet you need to sign your commits.

image

@chasecadet
Copy link
Contributor Author

@chasecadet you need to sign your commits.
Do I need to rebase then?

@thesuperzapper
Copy link
Member

Foundationally, this is still a discussion around if we have an "official" distribution or not.

This KEP proposes a single "mega" helm chart with all components inside, this is by definition, an opinionated "distribution" of Kubeflow Platform.

The community has discussed and rejected having official distributions in the past, for reasons that are still applicable:

  1. The fundamental goal of the project is to make AI/ML tools for Kubernetes (Pipelines, Notebooks, Trainer, Feature Store, etc.)
  2. Our strength is that our tools can run on any Kubernetes cluster, with no preference for any deployment method, cloud vendor, or anything else.
  3. If we make opinionated deployment decisions, less people will be able to adopt our tools, or include them in downstream platforms.
  4. There is strong evidence that it's not possible to create a successful "generic" distribution. See the fact that multiple successful distributions exist today, each with different opinionated approaches.
  5. Those in the OWNERS file of an official distribution would have the ability to make decisions that affect the whole community. This likely means that 1-3 consulting/cloud/platform companies make decisions that benefit them, rather than the goal of making our tools the standard.

PS: I want to stress that your motivations about making Kubeflow easier to use are great, and I am sure some users would love a Kubeflow Distribution that looks like this. (In fact, there are at least 2 that I am aware of which are similar to your proposal already, so perhaps you can collaborate with them). However, it's critical to keep the project neutral and focused on the tools themselves.


Also, while it's clearly not the intention of this KEP, there is a separate discussion around if automatically-generated helm charts based on the existing component kustomize manifests would be useful for downstream distributions. But that would be a completely separate proposal.

@varodrig
Copy link
Contributor

varodrig commented Mar 5, 2025

@chasecadet you need to sign your commits.
Do I need to rebase then?

Yes, here's the details and instructions you should folllow
https://github.com/kubeflow/community/runs/38211766217

@vikas-saxena02
Copy link

I think its a great initiative and I have already let @juliusvonkohout know that I am willing to contribute to it.

andreyvelich and others added 17 commits March 5, 2025 16:40
* Explain Transfer Ownership for KSC Members

Signed-off-by: Andrey Velichkevich <[email protected]>

* Add issue name

Signed-off-by: Andrey Velichkevich <[email protected]>

* Fix election link
Rename to DHL
Fix social media links

Signed-off-by: Andrey Velichkevich <[email protected]>

---------

Signed-off-by: Andrey Velichkevich <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
According to [kubeflow/website #3664](kubeflow/website#3664) and [clomonitor.io](https://clomonitor.io/projects/cncf/kubeflow#community) this readme should have a trademark disclaimer.

Signed-off-by: Paul Boyd <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
Updating format and some discussed content Signed-off-by: Chase Christensen [email protected]

Signed-off-by: Chase Christensen <[email protected]>
Updating the formatting.

Signed-off-by: Chase Christensen <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
juliusvonkohout and others added 3 commits March 5, 2025 16:46
Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
@chasecadet
Copy link
Contributor Author

DCO is still struggling.

@chasecadet
Copy link
Contributor Author

this is by definition, an opinionated "distribution" of Kubeflow Platform.

@thesuperzapper I want to make sure I fully understand your perspective, especially since you have a distribution. My goal is not to discourage contributions or distributions, so I have a few clarifying questions:

  • Does Kubeflow have a definition of an official distribution?
  • What criteria would prevent this from being perceived as an official distribution?
  • Can you provide examples of official distributions?
  • What are your concerns regarding official distributions?
  • How do projects with official distributions manage other distributions?
  • What impact, if any, do official distributions have on other distributions?
  • Do we need to clarify we are deploying only core components without opinionated changes?
  • How do we define opinionated changes v.s. a templating engine/tool?
  • Is our vanilla manifests + Kustomize considered a distribution?

Looking forward to your insights!

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Mar 6, 2025

  • Does Kubeflow have a definition of an official distribution?

  • What criteria would prevent this from being perceived as an official distribution?

  • Can you provide examples of official distributions?

  • What are your concerns regarding official distributions?

  • How do projects with official distributions manage other distributions?

  • What impact, if any, do official distributions have on other distributions?

  • Do we need to clarify we are deploying only core components without opinionated changes?

  • How do we define opinionated changes v.s. a templating engine/tool?

  • Is our vanilla manifests + Kustomize considered a distribution?

  • Does Kubeflow have a definition of an official distribution? Something that is derived from kubeflow/manifests. It can be one person in private or a large company in public or mixtures of that.
  • Is our kubeflow/manifests considered a distribution? No

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Mar 6, 2025

DCO is still struggling.

this is what i see in the tests
image

So one from me is also missing.

@vikas-saxena02
Copy link

DCO is still struggling.

Mate!! You need to sign-off your commits

@juliusvonkohout juliusvonkohout changed the title KEP 649-Kubeflow-Helm-Support: Support Helm as an Alternative for Kustomize KEP 831-Kubeflow-Helm-Support: Support Helm as an Alternative for Kustomize Mar 6, 2025
@juliusvonkohout
Copy link
Member

#831 as placeholder.

franciscojavierarceo and others added 2 commits March 6, 2025 15:00
* Adding a proposal for new projects to be included in KF

Signed-off-by: Francisco Javier Arceo <[email protected]>

* Updating format

Signed-off-by: Francisco Javier Arceo <[email protected]>

* Removing commented out section

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updated based on Andrey's and Johnu's feedback

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updated donation doc

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updated

Signed-off-by: Francisco Javier Arceo <[email protected]>

* add rough outline for doc

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updated based on andrey's feedback

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updated based on Andrey's feedback and adjusted language to 'join'

Signed-off-by: Francisco Javier Arceo <[email protected]>

* adding conformance

Signed-off-by: Francisco Javier Arceo <[email protected]>

* adjusting security section

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updated based on andrey's feedback

Signed-off-by: Francisco Javier Arceo <[email protected]>

* More adjustments

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updated

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updated

Signed-off-by: Francisco Javier Arceo <[email protected]>

* Update how-to/join_kubeflow_ecosystem.md

Co-authored-by: Anish Asthana <[email protected]>
Signed-off-by: Francisco Arceo <[email protected]>

* Update proposals/new-project-join-process.md

Co-authored-by: Anish Asthana <[email protected]>
Signed-off-by: Francisco Arceo <[email protected]>

* Update proposals/new-project-join-process.md

Co-authored-by: Anish Asthana <[email protected]>
Signed-off-by: Francisco Arceo <[email protected]>

* Update how-to/join_kubeflow_ecosystem.md

Co-authored-by: Anish Asthana <[email protected]>
Signed-off-by: Francisco Arceo <[email protected]>

* updated based on valentinas feedback

Signed-off-by: Francisco Javier Arceo <[email protected]>

* Update to include KSC Normal decision process

Signed-off-by: Francisco Javier Arceo <[email protected]>

* make more explicit about top section

Signed-off-by: Francisco Javier Arceo <[email protected]>

* adjusted based on Andrey's feedback

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updating based on johnu's feedback

Signed-off-by: Francisco Javier Arceo <[email protected]>

---------

Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Arceo <[email protected]>
Co-authored-by: Anish Asthana <[email protected]>
@juliusvonkohout
Copy link
Member

juliusvonkohout commented Mar 6, 2025

@chasecadet i think the branch is malformed, since it was not a rebase, but something else. It should change 1 file, not 39.

I have created #832 to continue. Please either close this PR with /close and continue in #832 or fix the branch, because otherwise we cannot merge it.

@juliusvonkohout
Copy link
Member

I got confirmation on slack from @chasecadet to continue in #832
/close

@google-oss-prow google-oss-prow bot closed this Mar 6, 2025
Copy link

@juliusvonkohout: Closed this PR.

In response to this:

I got confirmation on slack from @chasecadet to continue in #832
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants