Skip to content

Conversation

@asaadbalum
Copy link

…Hub Action to kubeflow/dashboard

Signed-off-by: Asaad Balum <[email protected]>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member

Thank you @asaadbalum, lets see what the tests say.

@juliusvonkohout
Copy link
Member

/ok-to-test

@thesuperzapper
Copy link
Member

/hold

@thesuperzapper
Copy link
Member

Please reach out to @kimwnasptd as he is now leading the effort to migrate code to this repo, thanks.

@asaadbalum
Copy link
Author

asaadbalum commented Jul 28, 2025

@kimwnasptd This PR is now ready for review after confirming we are targeting kubeflow/dashboard.

@asaadbalum
Copy link
Author

@kimwnasptd
I've resolved some merge conflict, and the tests was retriggered, a common error is:
"Image: "ghcr.io/kubeflow/dashboard/profile-controller:integration-test" with ID "sha256:a3a60ab9ac8c56669f95515807b034e40a2c164263fdd6f8553498662484d458" not yet present on node "kind-worker", loading...
Image: "ghcr.io/kubeflow/dashboard/profile-controller:integration-test" with ID "sha256:a3a60ab9ac8c56669f95515807b034e40a2c164263fdd6f8553498662484d458" not yet present on node "kind-control-plane", loading..."

might it be permissions issue?

@kimwnasptd
Copy link
Member

@asaadbalum could you try to specify the architecture when we build the images in the actions, like they were in the older repo?
https://github.com/kubeflow/kubeflow/blob/41ee8e7cb7cf57fa73b45362e67915c6a438c4aa/.github/workflows/centraldb_integration_test.yaml#L32

The other way around, let's try to run the steps of the CI locally to see what the error is. Hopefully, running the tests locally will become easier once #133 is merged

@andyatmiami
Copy link
Contributor

/close

superseded by #115 (which now contains these changes)

@google-oss-prow google-oss-prow bot closed this Aug 19, 2025
@google-oss-prow
Copy link

@andyatmiami: Closed this PR.

Details

In response to this:

/close

superseded by #115 (which now contains these changes)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants