-
Notifications
You must be signed in to change notification settings - Fork 41
ci: Migrate kubeflow/kubeflow prof_controller_docker_publish.yaml GitHub Action to kubeflow/dashboard #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Migrate kubeflow/kubeflow prof_controller_docker_publish.yaml GitHub Action to kubeflow/dashboard #117
Conversation
…Hub Action to kubeflow/dashboard Signed-off-by: Asaad Balum <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thank you @asaadbalum, lets see what the tests say. |
|
/ok-to-test |
|
/hold |
|
Please reach out to @kimwnasptd as he is now leading the effort to migrate code to this repo, thanks. |
|
@kimwnasptd This PR is now ready for review after confirming we are targeting kubeflow/dashboard. |
Signed-off-by: asaadbalum <[email protected]>
|
@kimwnasptd might it be permissions issue? |
|
@asaadbalum could you try to specify the architecture when we build the images in the actions, like they were in the older repo? The other way around, let's try to run the steps of the CI locally to see what the error is. Hopefully, running the tests locally will become easier once #133 is merged |
|
/close superseded by #115 (which now contains these changes) |
|
@andyatmiami: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
related: #74

https://hub.docker.com/repository/docker/abalumrh/nb2/image-management
The successful job:
