Skip to content

Conversation

@kimwnasptd
Copy link
Member

Follow up of #152

Now that the merged Profile Controller is correctly pointing to kubeflow/dashboard we can update access-management as well. More details in #152 (comment).

/cc @andyatmiami @juliusvonkohout

Feel free to also add other reviewers as you see fit

@kimwnasptd kimwnasptd force-pushed the fix-kfam-go-module-path branch from 8d4ba1f to fd93c60 Compare October 8, 2025 11:40
module github.com/kubeflow/dashboard/components/access-management

go 1.17
go 1.20
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I was getting issues with 1.17 previously when running go mod tidy, that's why I updated this version:

go mod tidy
go: downloading github.com/golang/groupcache v0.0.0-20180513044358-24b0969c4cb7
go: downloading github.com/onsi/ginkgo v1.6.0
go: downloading github.com/onsi/gomega v1.4.2
go: downloading github.com/hpcloud/tail v1.0.0
go: downloading gopkg.in/fsnotify.v1 v1.4.7
go: finding module for package github.com/kubeflow/dashboard/components/profile-controller/api/v1beta1
go: downloading github.com/kubeflow/dashboard v0.0.0-20251008104113-dc123d01db8d
go: downloading github.com/kubeflow/dashboard/components/profile-controller v0.0.0-20251008104113-dc123d01db8d
go: found github.com/kubeflow/dashboard/components/profile-controller/api/v1beta1 in github.com/kubeflow/dashboard/components/profile-controller v0.0.0-20251008104113-dc123d01db8d
go: downloading sigs.k8s.io/controller-runtime v0.12.1
go: downloading github.com/prometheus/client_golang v1.12.1
go: downloading github.com/sirupsen/logrus v1.8.1
go: downloading istio.io/api v0.0.0-20220525153140-e3c48c9ac324
go: downloading istio.io/client-go v1.13.4
go: downloading github.com/stretchr/testify v1.7.0
go: downloading golang.org/x/oauth2 v0.0.0-20211104180415-d3ed0bb246c8
go: downloading golang.org/x/time v0.0.0-20220210224613-90d013bbcef8
go: downloading gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b
go: downloading github.com/cespare/xxhash/v2 v2.1.2
go: downloading github.com/prometheus/common v0.32.1
go: downloading github.com/prometheus/procfs v0.7.3
go: downloading github.com/onsi/gomega v1.18.1
go: downloading golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1
go: downloading google.golang.org/genproto v0.0.0-20220107163113-42d7afdf6368
go: downloading github.com/golang/glog v1.0.0
go: downloading github.com/google/btree v1.0.1
go: github.com/kubeflow/dashboard/components/access-management/kfam imports
        github.com/gorilla/mux loaded from github.com/gorilla/[email protected],
        but go 1.16 would select v1.8.0
go: github.com/kubeflow/dashboard/components/access-management/kfam imports
        k8s.io/apimachinery/pkg/labels imports
        github.com/golang/glog loaded from github.com/golang/[email protected],
        but go 1.16 would select v1.0.0
go: github.com/kubeflow/dashboard/components/access-management/kfam imports
        k8s.io/client-go/kubernetes imports
        k8s.io/client-go/discovery imports
        github.com/peterbourgon/diskv imports
        github.com/google/btree loaded from github.com/google/[email protected],
        but go 1.16 would select v1.0.1

To upgrade to the versions selected by go 1.16:
        go mod tidy -go=1.16 && go mod tidy -go=1.17
If reproducibility with go 1.16 is not needed:
        go mod tidy -compat=1.17
For other options, see:
        https://golang.org/doc/modules/pruning
go: github.com/kubeflow/dashboard/components/access-management/kfam imports
        github.com/gorilla/mux loaded from github.com/gorilla/[email protected],
        but go 1.16 would select v1.8.0
go: github.com/kubeflow/dashboard/components/access-management/kfam imports
        k8s.io/apimachinery/pkg/labels imports
        github.com/golang/glog loaded from github.com/golang/[email protected],
        but go 1.16 would select v1.0.0
go: github.com/kubeflow/dashboard/components/access-management/kfam imports
        k8s.io/client-go/kubernetes imports
        k8s.io/client-go/discovery imports
        github.com/peterbourgon/diskv imports
        github.com/google/btree loaded from github.com/google/[email protected],
        but go 1.16 would select v1.0.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could very well help resolve some Trivy vulnerabilities as well 😎

@kimwnasptd
Copy link
Member Author

/ok-to-test

Copy link
Contributor

@andyatmiami andyatmiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes @kimwnasptd ! From a static and quasi-dynamic review - I think these changes are good!

I feel comfortable with the go.mod change (and affected go.sum) to leverage go 1.20. I also searched the components/access-management directory and can confirm no remaining reference to the string kubeflow/kubeflow.

Obviously the GHA checks are fairly robust in verifying a change such as this - but I also still updated a running kind cluster with a (partial) Kubeflow installation and verified the workloads modified in this PR enter a healthy RUNNING state within the cluster.

Testing Methodology

  • create a minimal Kubeflow deployment using a custom script of mine
    ./setup-kubeflow-notebooks.sh --force

  • build access-management image from PR and load into kind

    $ DOCKER_BUILDKIT=0 gmake docker-build IMG=quay.io/rh-ee-astonebe/kubeflow-dashboard TAG=kfam-gomod-verify
    $ kind load docker-image quay.io/rh-ee-astonebe/kubeflow-dashboard:kfam-gomod-verify --name kubeflow
    
  • build profile-controller image from PR (inherited from main) and load into kind

    $ DOCKER_BUILDKIT=0 gmake docker-build IMG=quay.io/rh-ee-astonebe/kubeflow-dashboard TAG=profcon-gomod-verify
    $ kind load docker-image quay.io/rh-ee-astonebe/kubeflow-dashboard:profcon-gomod-verify --name kubeflow
    
  • edit profiles-deployment to use custom images for profile-controller and access-management
    $ kubectl -n kubeflow edit deployment/profiles-deployment

  • confirm workloads stay in healthy state
    $ kubectl get deployments,replicasets,pods -n kubeflow

@kimwnasptd
Copy link
Member Author

Thank you for the very thorough review @andyatmiami!

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 6eb7103 into kubeflow:main Oct 8, 2025
15 checks passed
@kimwnasptd kimwnasptd deleted the fix-kfam-go-module-path branch October 9, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants