fix: Fix Kustomize v5 warnings #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: milinddethe15 <[email protected]>
Signed-off-by: milinddethe15 <[email protected]>
milinddethe15
changed the title
milinddethe15
changed the title
Member
|
@akagami-harsh @kunal-511 can you verify that the |
Contributor
|
For centraldashboard-angular there is no difference before and after the PR
|
Contributor
|
For admission-webhook
|
Member
|
If it is only one istio label thank you and /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/ok-to-test |
yehudit1987
pushed a commit
to yehudit1987/dashboard
that referenced
this pull request
Jul 3, 2025
* manifest: fix Kustomize 5 warnings in `admission-webhook` Signed-off-by: milinddethe15 <[email protected]> * manifest: fix Kustomize 5 warnings in `centraldashboard-angular` Signed-off-by: milinddethe15 <[email protected]> --------- Signed-off-by: milinddethe15 <[email protected]> ci: Enhance the GHA (kubeflow#101) * Enhance the GHA Signed-off-by: kunal-511 <[email protected]> * Updated the trigger paths Signed-off-by: kunal-511 <[email protected]> * Updated the format Signed-off-by: kunal-511 <[email protected]> * Updated the env and labels Signed-off-by: kunal-511 <[email protected]> * Updated gha to fix errors Signed-off-by: kunal-511 <[email protected]> * Added logs to know error Signed-off-by: kunal-511 <[email protected]> * Removed logs Signed-off-by: kunal-511 <[email protected]> * Update the end point call Signed-off-by: kunal-511 <[email protected]> * Updated the deployment name Signed-off-by: kunal-511 <[email protected]> * Updated the validate-webhook function to use the correct mutating webhook configuration name Signed-off-by: kunal-511 <[email protected]> * updated pod testing Signed-off-by: kunal-511 <[email protected]> * Updated the the kind version Signed-off-by: kunal-511 <[email protected]> * updated namespace Signed-off-by: kunal-511 <[email protected]> * Fixed certificate error Signed-off-by: kunal-511 <[email protected]> * Fixed the casing in docker file Signed-off-by: kunal-511 <[email protected]> * Updated the kfam deployment Signed-off-by: kunal-511 <[email protected]> * Updated the service name Signed-off-by: kunal-511 <[email protected]> * Updated the api call Signed-off-by: kunal-511 <[email protected]> * updated endpoints Signed-off-by: kunal-511 <[email protected]> * Updated the env for end to end test Signed-off-by: kunal-511 <[email protected]> * Updated port forwarding Signed-off-by: kunal-511 <[email protected]> * Port mapping updated Signed-off-by: kunal-511 <[email protected]> * removed logs Signed-off-by: kunal-511 <[email protected]> * Added timeout Signed-off-by: kunal-511 <[email protected]> * Updated the logs Signed-off-by: kunal-511 <[email protected]> * Updated the naming Signed-off-by: kunal-511 <[email protected]> * Updated the naming Signed-off-by: kunal-511 <[email protected]> * Fixed naming Signed-off-by: kunal-511 <[email protected]> --------- Signed-off-by: kunal-511 <[email protected]> testing Migrate kubeflow/kubeflow centraldb_docker_publish.yaml GitHub Action to kubeflow/dashboard - initial Signed-off-by: Yehudit Kerido <[email protected]> testing testing testing testing ci: Migrate kubeflow/kubeflow centraldb_docker_publish.yaml GitHub Action to kubeflow/dashboard Signed-off-by: Yehudit Kerido <[email protected]>
This was referenced Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of kubeflow/manifests#2991
Fixes some of the warnings, when applying the manifests for:
For Profile-controller, not sure that the manifests are valid.
https://github.com/kubeflow/dashboard/blob/main/components/profile-controller/config/base/kustomization.yaml#L1