Skip to content

fix: stateless tests#1244

Merged
google-oss-prow[bot] merged 6 commits intokubeflow:mainfrom
Al-Pragliola:al-pragliola-fix-stateless-tests
Jun 26, 2025
Merged

fix: stateless tests#1244
google-oss-prow[bot] merged 6 commits intokubeflow:mainfrom
Al-Pragliola:al-pragliola-fix-stateless-tests

Conversation

@Al-Pragliola
Copy link
Copy Markdown
Contributor

@Al-Pragliola Al-Pragliola commented Jun 25, 2025 •
edited
Loading

Description

This PR addressed failed tests from #1242

How Has This Been Tested?

Tested locally by comparing responses from the MLMD version and the current one

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@Al-Pragliola Al-Pragliola marked this pull request as ready for review June 25, 2025 14:18
@google-oss-prow google-oss-prow Bot requested review from Tomcli and tarilabs June 25, 2025 14:18
pboyd
pboyd approved these changes Jun 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@pboyd pboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow Bot added lgtm and removed lgtm labels Jun 25, 2025
fege
fege approved these changes Jun 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@fege fege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow
Copy link
Copy Markdown
Contributor

google-oss-prow Bot commented Jun 26, 2025

@fege: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fege
Copy link
Copy Markdown
Contributor

fege commented Jun 26, 2025

tested locally running schemathesis and no error

tarilabs
tarilabs approved these changes Jun 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic work @Al-Pragliola @fege in coordination, really appreciated

/approve

@Al-Pragliola
fix: stateless tests
94812f8 
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
@Al-Pragliola
fix: unit tests
5f1c62c 
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
@Al-Pragliola
fix: other stateless tests
04114d5 
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
@Al-Pragliola
fix: unit tests
2f05d87 
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
@Al-Pragliola
fix: 409 status code missing errors
802f5eb 
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
@Al-Pragliola
fix: nil pointer panics
a461440 
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
@Al-Pragliola Al-Pragliola force-pushed the al-pragliola-fix-stateless-tests branch from 47f0e7c to a461440 Compare June 26, 2025 09:13
@google-oss-prow google-oss-prow Bot removed the lgtm label Jun 26, 2025
@tarilabs
Copy link
Copy Markdown
Member

tarilabs commented Jun 26, 2025

fantastic work @Al-Pragliola @fege in coordination, really appreciated

/approve

@google-oss-prow
Copy link
Copy Markdown
Contributor

google-oss-prow Bot commented Jun 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tarilabs
Copy link
Copy Markdown
Member

tarilabs commented Jun 26, 2025

/lgtm

@google-oss-prow google-oss-prow Bot added the lgtm label Jun 26, 2025
@google-oss-prow google-oss-prow Bot merged commit 332c9ae into kubeflow:main Jun 26, 2025
15 checks passed
@Al-Pragliola Al-Pragliola deleted the al-pragliola-fix-stateless-tests branch June 26, 2025 10:08
@Al-Pragliola Al-Pragliola mentioned this pull request Jun 26, 2025
Merged
@tarilabs tarilabs mentioned this pull request Jan 23, 2026
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pboyd pboyd pboyd approved these changes

@tarilabs tarilabs tarilabs approved these changes

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@rareddy rareddy Awaiting requested review from rareddy

@Tomcli Tomcli Awaiting requested review from Tomcli

+1 more reviewer

@fege fege fege approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pboyd pboyd

@tarilabs tarilabs

Labels

approved Area/Go REST server lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Al-Pragliola @fege @tarilabs @pboyd