Skip to content

fix: add backoff also to postgresql#1263

Merged
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
Al-Pragliola:al-pragliola-fix-postgresql-backoff
Jul 2, 2025
Merged

fix: add backoff also to postgresql#1263
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
Al-Pragliola:al-pragliola-fix-postgresql-backoff

Conversation

@Al-Pragliola
Copy link
Copy Markdown
Contributor

@Al-Pragliola Al-Pragliola commented Jul 1, 2025

Description

Applying the same logic from #1246 to postgresql

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
Copy link
Copy Markdown
Member

@pboyd pboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rareddy
Copy link
Copy Markdown
Contributor

rareddy commented Jul 1, 2025

Maybe we should extract the connection as a Strategy and apply it across?

Copy link
Copy Markdown
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @Al-Pragliola

/approve

@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit edaacad into kubeflow:main Jul 2, 2025
16 checks passed
@Al-Pragliola Al-Pragliola deleted the al-pragliola-fix-postgresql-backoff branch July 2, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants