support hf api model retrieval basic md#1852
support hf api model retrieval basic md#1852google-oss-prow[bot] merged 17 commits intokubeflow:mainfrom
Conversation
Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com>
Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com>
Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com>
Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com>
Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com>
Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com>
Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com>
Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com>
Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com>
Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com>
|
Hey @adysenrothman great job! I tried running the sample sources file for hf from the README but I got the following errors: seems like the gated field is defined as string, but HuggingFace returns it as false (boolean) for non-gated models and "auto" or "manual" (string) for gated ones. |
I'll check on that, thanks for taking a look! |
Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com>
Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com>
Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com>
Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com>
pboyd
left a comment
There was a problem hiding this comment.
Thanks for the changes.
/lgtm
/retest
Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pboyd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR sets up a basic Hugging Face implementation for the model catalog.
Description
How Has This Been Tested?
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes