Skip to content

Add Openapi spec and STUB endpoint for source_preview#1884

Merged
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
ppadti:source-preview-endpoint
Nov 20, 2025
Merged

Add Openapi spec and STUB endpoint for source_preview#1884
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
ppadti:source-preview-endpoint

Conversation

@ppadti
Copy link
Copy Markdown
Contributor

@ppadti ppadti commented Nov 19, 2025

Description

This PR aims to add source_preview endpoint. Added types, mocks.

How Has This Been Tested?

run the application:
make dev-start

test the curl command:
for HF:

curl -X POST "http://localhost:4000/api/v1/settings/model_catalog/source_preview?namespace=kubeflow" \
  -H "Content-Type: application/json" \
  -H "kubeflow-userid: user@example.com" \
  -d '{
    "type": "huggingface"
  }' 

for yaml type:

curl -X POST "http://localhost:4000/api/v1/settings/model_catalog/source_preview?namespace=kubeflow" \
  -H "Content-Type: application/json" \
  -H "kubeflow-userid: user@example.com" \
  -d '{
    "type": "yaml"
  }'

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@github-actions github-actions Bot added Area/UI and removed size/L labels Nov 19, 2025
@ppadti ppadti changed the title Add Openapi spec and STUB endpoints for source_preview Add Openapi spec and STUB endpoint for source_preview Nov 19, 2025
@mturley
Copy link
Copy Markdown
Contributor

mturley commented Nov 19, 2025

/lgtm
/approve

ah @ppadti there is a merge conflict though

Signed-off-by: ppadti <ppadti@redhat.com>
@ppadti ppadti force-pushed the source-preview-endpoint branch from bd5e220 to 9d935ec Compare November 20, 2025 07:45
@google-oss-prow google-oss-prow Bot removed the lgtm label Nov 20, 2025
@mturley
Copy link
Copy Markdown
Contributor

mturley commented Nov 20, 2025

/lgtm
/approve

@google-oss-prow google-oss-prow Bot added the lgtm label Nov 20, 2025
@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit 847b9d8 into kubeflow:main Nov 20, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants