Skip to content

Catalog: Round latency to 2 decimal places, remove commented out code for average accuracy on cards#1898

Merged
google-oss-prow[bot] merged 3 commits intokubeflow:mainfrom
mturley:round-ms
Nov 25, 2025
Merged

Catalog: Round latency to 2 decimal places, remove commented out code for average accuracy on cards#1898
google-oss-prow[bot] merged 3 commits intokubeflow:mainfrom
mturley:round-ms

Conversation

@mturley
Copy link
Copy Markdown
Contributor

@mturley mturley commented Nov 21, 2025

Description

We neglected to call the formatLatency util when displaying latency metrics on the cards in the catalog landing page. This fixes that, truncating the number to 2 decimal places.

(screenshot is outdated mock data, disregard the logo)
Screenshot 2025-11-21 at 2 35 53 PM

Also, we had left commented-out code around this card area for the average accuracy metric, which we expected to reinstate later but has now been excluded from the design. Removing that dead code while I'm in here.

How Has This Been Tested?

Ran in mock mode, observed that the number is rounded correctly.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

…age accuracy on cards

Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
Copy link
Copy Markdown
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@manaswinidas
Copy link
Copy Markdown
Contributor

@mturley There's a linting error

Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
@google-oss-prow google-oss-prow Bot removed the lgtm label Nov 24, 2025
@mturley
Copy link
Copy Markdown
Contributor Author

mturley commented Nov 24, 2025

@manaswinidas thanks, fixed

@manaswinidas
Copy link
Copy Markdown
Contributor

@mturley Cypress test failing

Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
@mturley
Copy link
Copy Markdown
Contributor Author

mturley commented Nov 24, 2025

@manaswinidas ugh sorry, fixed again

@mturley
Copy link
Copy Markdown
Contributor Author

mturley commented Nov 24, 2025

/retest

Copy link
Copy Markdown
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow Bot added the lgtm label Nov 25, 2025
@manaswinidas
Copy link
Copy Markdown
Contributor

/approve

@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manaswinidas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit 4320bad into kubeflow:main Nov 25, 2025
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants