Refactor envtest mocks & client logic for catalog-source ConfigMap handling

[ederign]

Description

This PR is a starting point for refactoring based on my conversations with @ppadti. I left a considerable number of TODOs that will be addressed by @ppadti in a FUP PR.

This change aligns our handling of the model-catalog-default-sources and model-catalog-sources ConfigMaps and aligns our test/mock environment (envtest).

In this PR:

• Reverted modelCatalogSettingsRepository mock creation to align with your k8s mock strategy
• Implemented GetAllCatalogSourceConfigs for the default catalog
• Setup env test for model-catalog-source-config

Next steps:

FUP PR from @ppadti to write the full implementation

How Has This Been Tested?

run the application in mock mode
make dev-start

try these curl commands:

get all source configs:

curl -X GET "http://localhost:4000/api/v1/settings/model_catalog/source_configs?namespace=kubeflow" -H "kubeflow-userid: user@example.com"

add a catalog source config:

curl -X POST "http://localhost:4000/api/v1/settings/model_catalog/source_configs?namespace=kubeflow" -H "kubeflow-userid: user@example.com" -H "Content-Type: application/json" -d '{"data":{"id":"test-catalog","name":"Test Catalog","type":"yaml"}}' 

get a catalog source config:

curl -s "http://localhost:4000/api/v1/settings/model_catalog/source_configs/test-catalog?namespace=kubeflow" -H "kubeflow-userid: user@example.com" 

Update a catalog source config:

curl -X PATCH "http://localhost:4000/api/v1/settings/model_catalog/source_configs/test-catalog?namespace=kubeflow" -H "kubeflow-userid: user@example.com" -H "Content-Type: application/json" -d '{"data":{"id":"test-catalog","name":"Updated Catalog","type":"yaml"}}'

Delete a catalog source config:

curl -X DELETE "http://localhost:4000/api/v1/settings/model_catalog/source_configs/test-catalog?namespace=kubeflow" -H "kubeflow-userid: user@example.com"

Merge criteria:

• All the commits have been signed-off (To pass the DCO check)

• The commits have meaningful messages
• Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work.
• Code changes follow the kubeflow contribution guidelines.

[ederign]

/assign @ppadti

[google-oss-prow]

@ederign: GitHub didn't allow me to assign the following users: ppadti.

Note that only kubeflow members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @ppadti

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ederign]

/hold

[ederign]

Hold until @ppadti does the rest of the refactoring.

[ederign]

/unhold

[ederign]

@ppadti, your changes lgtm!

[mturley]

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• clients/ui/OWNERS [mturley]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment