Skip to content

chore: remove unused direct dependency#1926

Closed
tarilabs wants to merge 1 commit intokubeflow:mainfrom
tarilabs:tarilabs-20251126-attemptRemoveDep
Closed

chore: remove unused direct dependency#1926
tarilabs wants to merge 1 commit intokubeflow:mainfrom
tarilabs:tarilabs-20251126-attemptRemoveDep

Conversation

@tarilabs
Copy link
Copy Markdown
Member

Description

There is no reference to this direct dependency, beside the comment which might be superseeded by newer pydantic versions which we bumped in the meantime

How Has This Been Tested?

raising this PR in draft so to execute suite in entirety

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tarilabs. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tarilabs
Copy link
Copy Markdown
Member Author

resolving this PR as the dependency is still needed by the code-generated, annotated #1911 (review)

@tarilabs tarilabs closed this Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant