Skip to content

Fix search bar for Model and MCP Catalog#2567

Merged
google-oss-prow[bot] merged 2 commits intokubeflow:mainfrom
Philip-Carneiro:fix-model-and-mcp-catalog-search
Apr 10, 2026
Merged

Fix search bar for Model and MCP Catalog#2567
google-oss-prow[bot] merged 2 commits intokubeflow:mainfrom
Philip-Carneiro:fix-model-and-mcp-catalog-search

Conversation

@Philip-Carneiro
Copy link
Copy Markdown
Contributor

@Philip-Carneiro Philip-Carneiro commented Apr 10, 2026

Description

The search bar in the Model Catalog and MCP Catalog pages was not stretching to fill the available toolbar width. This caused the placeholder text and search input to be cut off, making it difficult for users to see what they were typing or reading.

Root cause: The FormFieldset component (used for MUI theme rendering) was replacing its base CSS class instead of concatenating it

  • Updated ModelCatalogSourceLabelSelector and McpCatalogSourceLabelSelector toolbar layout to use flex: 1 at each nesting level (FlexToolbarToggleGroupToolbarGroupToolbarItem), allowing the search bar to stretch to fill the available space
  • Removed hardcoded minWidth/maxWidth constraints that conflicted with the flex layout

Non-PF mode:
image
image

PF mode:

image image

How Has This Been Tested?

It was manually tested, no unit or cypress test are added since it was just style rendering issue

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Made-with: Cursor
Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
@Philip-Carneiro Philip-Carneiro force-pushed the fix-model-and-mcp-catalog-search branch from 5a9b288 to 5ce84c6 Compare April 10, 2026 10:08
Copy link
Copy Markdown
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add screenshots in the PR description

@Philip-Carneiro
Copy link
Copy Markdown
Contributor Author

Please add screenshots in the PR description

Sorry, the PR was only to see if is possible for the solution work after synched, and it's working fine

Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
@Philip-Carneiro Philip-Carneiro requested a review from ppadti April 10, 2026 14:14
@ppadti
Copy link
Copy Markdown
Contributor

ppadti commented Apr 10, 2026

I tested this midstream - I see this:
Screenshot 2026-04-10 at 8 20 13 PM
Screenshot 2026-04-10 at 8 20 07 PM

bit different in terms of length than what we are seeing upstream with patternfly theme - Is that expected?

@Philip-Carneiro
Copy link
Copy Markdown
Contributor Author

I tested this midstream - I see this: Screenshot 2026-04-10 at 8 20 13 PM Screenshot 2026-04-10 at 8 20 07 PM

bit different in terms of length than what we are seeing upstream with patternfly theme - Is that expected?

This is because how this is rendered by the midstream, but now we removed the forced styles and changes from midstream and show the entire placeholder. If a new content come at the right side or left side it will work normal because the flex change

Copy link
Copy Markdown
Contributor

@ppadti ppadti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Philip-Carneiro
/lgtm

@google-oss-prow google-oss-prow Bot added the lgtm label Apr 10, 2026
@mturley
Copy link
Copy Markdown
Contributor

mturley commented Apr 10, 2026

/approve
/lgtm
Thank you @Philip-Carneiro

@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit 5ea29b0 into kubeflow:main Apr 10, 2026
31 checks passed
@mturley
Copy link
Copy Markdown
Contributor

mturley commented Apr 10, 2026

@Philip-Carneiro I realize after approving this - it's fine for now, but the CSS here affects anything with .toolbar-fieldset-wrapper which is also present in MR, so we should make double check it's having the intended effect there and if there's a problem we need to scope it to catalog. From a quick check it seems fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants