fix(ui): DeleteModal and MCP details view changes#2569
Merged
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom Apr 10, 2026
Merged
fix(ui): DeleteModal and MCP details view changes#2569google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
Conversation
Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manaswinidas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DeleteModal.tsxconfirmationRequiredIndicatorprop (defaults tofalse) that appends a required indicator (*) after the confirmation prompt text when enabled. This supports downstream consumers (e.g., MCP deployment deletion) that need to visually mark the confirmation field as required.data-testid="delete-modal-confirm-button"on the danger/confirmButtonto improve testability — downstream Cypress tests target this selector.McpServerDetailsView.tsx:DescriptionListTermto follow sentence-case convention consistent with other labels on the page (e.g., "Deployment mode", "Transport type").How Has This Been Tested?
Merge criteria:
All the commits have been signed-off (To pass the
DCOcheck)The commits have meaningful messages
Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work.
Code changes follow the kubeflow contribution guidelines.
For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label
ok-to-testhas been added to the PR.If you have UI changes