Skip to content

fix(ui): DeleteModal and MCP details view changes#2569

Merged
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
YuliaKrimerman:mcp-microcopy
Apr 10, 2026
Merged

fix(ui): DeleteModal and MCP details view changes#2569
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
YuliaKrimerman:mcp-microcopy

Conversation

@YuliaKrimerman
Copy link
Copy Markdown
Contributor

@YuliaKrimerman YuliaKrimerman commented Apr 10, 2026

Description

DeleteModal.tsx

  • Added an optional confirmationRequiredIndicator prop (defaults to false) that appends a required indicator (*) after the confirmation prompt text when enabled. This supports downstream consumers (e.g., MCP deployment deletion) that need to visually mark the confirmation field as required.
  • Added data-testid="delete-modal-confirm-button" on the danger/confirm Button to improve testability — downstream Cypress tests target this selector.

McpServerDetailsView.tsx:

  • Fixed microcopy: changed "Source Code" → "Source code" in the DescriptionListTerm to follow sentence-case convention consistent with other labels on the page (e.g., "Deployment mode", "Transport type").
Screenshot 2026-04-10 at 10 52 43 AM

How Has This Been Tested?

  • Manual code review confirmed backward compatibility (optional prop with default, additive test ID).

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)

  • The commits have meaningful messages

  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).

  • The developer has manually tested the changes and verified that the changes work.

  • Code changes follow the kubeflow contribution guidelines.

  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>
Copy link
Copy Markdown
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots please

Copy link
Copy Markdown
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manaswinidas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit 8f5d780 into kubeflow:main Apr 10, 2026
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants