chore(ui): remove license values UI mapping in model catalog#2596
Conversation
Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>
|
/retest |
manaswinidas
left a comment
manaswinidas
left a comment
There was a problem hiding this comment.
The static_data_mock.go license values should be updated too to keep mock data consistent with the real API.
manaswinidas
left a comment
manaswinidas
left a comment
There was a problem hiding this comment.
Clean removal overall. One inline suggestion (non-blocking).
| title="License" | ||
| filterKey={filterKey} | ||
| filterToNameMapping={MODEL_CATALOG_LICENSE_NAME_MAPPING} | ||
| filterToNameMapping={{}} |
There was a problem hiding this comment.
suggestion (nit): Consider making filterToNameMapping optional (with a default of {}) in ModelCatalogStringFilter so this prop can simply be omitted here rather than passing an empty object.
Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>
|
/retest |
manaswinidas
left a comment
manaswinidas
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Thanks!! All review comments addressed.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manaswinidas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…w#2596) * removed UI mapping for licence values Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com> * addressed comments Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com> --------- Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>
2 participants
Description
Now that the backend sends human-readable license names directly, the frontend no longer needs its own slug-to-readable-name mapping for license values.
This PR removes the
ModelCatalogLicenseenum,MODEL_CATALOG_LICENSE_NAME_MAPPING, andMODEL_CATALOG_LICENSE_DETAILSfrom the model catalog constants, and updates all consumers to treat license values as plain strings from the API. TheModelCatalogStringFiltercomponent already had a fallback to the raw value when no mapping entry existed, so this change is seamless — the UI continues to display license names exactly as the API provides them.**Changes across 6 files (20 additions, 110 deletions)
How Has This Been Tested?
ModelCatalogLicensereferences are fully removed (grep confirms zero remaining usages).Merge criteria:
All the commits have been signed-off (To pass the
DCOcheck)The commits have meaningful messages
Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work.
Code changes follow the kubeflow contribution guidelines.
For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label
ok-to-testhas been added to the PR.