Simplify error message body for catalog source connection errors#2601
Closed
Taj010 wants to merge 1 commit intokubeflow:mainfrom
Closed
Simplify error message body for catalog source connection errors#2601Taj010 wants to merge 1 commit intokubeflow:mainfrom
Taj010 wants to merge 1 commit intokubeflow:mainfrom
Conversation
Signed-off-by: Taj010 <rsheen003@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
8 tasks
Contributor
|
this change will not be necessary after merge of #2526 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The source status error modal suggested checking the organization and retrying, which implies causes (org / access token) the UI does not support and may be wrong. This PR adjusted it to show a single neutral line: “The system cannot establish a connection to the source.” The full backend error string is shown unchanged below it (via existing errorMessage prop from CatalogSourceStatus).
How Has This Been Tested?
Manually: Model Catalog Settings → source in error state → click the failed/error link → confirm the modal shows only the short intro line, then the exact backend error text with no org/credential troubleshooting sentence.
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes