Skip to content

Simplify error message body for catalog source connection errors#2601

Closed
Taj010 wants to merge 1 commit intokubeflow:mainfrom
Taj010:simplify-error-message
Closed

Simplify error message body for catalog source connection errors#2601
Taj010 wants to merge 1 commit intokubeflow:mainfrom
Taj010:simplify-error-message

Conversation

@Taj010
Copy link
Copy Markdown
Contributor

@Taj010 Taj010 commented Apr 15, 2026

Description

The source status error modal suggested checking the organization and retrying, which implies causes (org / access token) the UI does not support and may be wrong. This PR adjusted it to show a single neutral line: “The system cannot establish a connection to the source.” The full backend error string is shown unchanged below it (via existing errorMessage prop from CatalogSourceStatus).

How Has This Been Tested?

Manually: Model Catalog Settings → source in error state → click the failed/error link → confirm the modal shows only the short intro line, then the exact backend error text with no org/credential troubleshooting sentence.

image

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • [] Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: Taj010 <rsheen003@gmail.com>
@google-oss-prow google-oss-prow Bot requested review from chambridge and fege April 15, 2026 19:39
@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yuliakrimerman for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Philip-Carneiro
Copy link
Copy Markdown
Contributor

this change will not be necessary after merge of #2526

@Taj010 Taj010 closed this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants