fix(ui): MUI theme overlap in YamlSection#2607
Closed
PratikMane0112 wants to merge 1 commit intokubeflow:mainfrom
Closed
fix(ui): MUI theme overlap in YamlSection#2607PratikMane0112 wants to merge 1 commit intokubeflow:mainfrom
PratikMane0112 wants to merge 1 commit intokubeflow:mainfrom
Conversation
Fixes #2606 Signed-off-by: PratikMane0112 <prmane@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
|
cc @manaswinidas, can you please comment |
Contributor
|
/ok-to-test |
Contributor
|
this is fixed in other PR #2526 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2606
In MUI theme mode, the YAML content section in
Model Catalog Sourceshad two issues:Description
Changes done in
FormGrouplabel to a plain string for correct floating label rendering & moved the "View expected file format" button outside theFormGroup.How Has This Been Tested?
modelCatalogSettings suite pass
manual verification with
STYLE_THEME=mui-theme npm run start:devbefore :
after :
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes