Skip to content

fix(ui): MUI theme overlap in YamlSection#2607

Closed
PratikMane0112 wants to merge 1 commit intokubeflow:mainfrom
PratikMane0112:fix/mui-theme-overlap-in-yaml-section
Closed

fix(ui): MUI theme overlap in YamlSection#2607
PratikMane0112 wants to merge 1 commit intokubeflow:mainfrom
PratikMane0112:fix/mui-theme-overlap-in-yaml-section

Conversation

@PratikMane0112
Copy link
Copy Markdown

Fixes #2606

In MUI theme mode, the YAML content section in Model Catalog Sources had two issues:

  • view expected file format button was unclickable
  • text elements overlapped within the form label area

Description

Changes done in

  • MUI mode : simplified the FormGroup label to a plain string for correct floating label rendering & moved the "View expected file format" button outside the FormGroup.
  • PF mode: unchanged.

How Has This Been Tested?

  • modelCatalogSettings suite pass

  • manual verification with STYLE_THEME=mui-theme npm run start:dev

    • before :

      Screenshot 2026-04-19 at 9 46 11 PM
    • after :

      Screenshot 2026-04-19 at 9 55 27 PM

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Fixes #2606

Signed-off-by: PratikMane0112 <prmane@redhat.com>
@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign griffin-sullivan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot requested review from chambridge and fege April 19, 2026 18:04
@PratikMane0112
Copy link
Copy Markdown
Author

cc @manaswinidas, can you please comment ok-to-test, this my first patch & also I am ready to do further changes, if needed :)

@manaswinidas
Copy link
Copy Markdown
Contributor

/ok-to-test

@Philip-Carneiro
Copy link
Copy Markdown
Contributor

this is fixed in other PR #2526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix overlapping text and layout issues in MUI for model catalog sources admins

3 participants