chore(bff): use the latest openapi changes#2634
Open
pboyd wants to merge 1 commit intokubeflow:mainfrom
Open
Conversation
aa2e8f9 to
a589031
Compare
a589031 to
c364c47
Compare
Contributor
|
Tried it locally, |
Member
Author
|
I need to rebase this and fix the problem @Al-Pragliola reported. /hold |
Use a replace directive in `clients/ui/bff` for `github.com/kubeflow/hub/pkg/openapi` so it's always on the latest version. Patching changes needed from kubeflow#1820 that were never brought into the BFF. Signed-off-by: Paul Boyd <paul@pboyd.io>
c364c47 to
597a62a
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
@Al-Pragliola, it's fixed now, thanks. /unhold |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use a replace directive in
clients/ui/bffforgithub.com/kubeflow/model-registry/pkg/openapiso it's always on the latest version, and rename it togithub.com/kubeflow/hub/pkg/openapi.Patching changes needed from #1820 that were never brought into the BFF.
How Has This Been Tested?
Merge criteria:
DCOcheck)