Skip to content

chore(bff): use the latest openapi changes#2634

Open
pboyd wants to merge 1 commit intokubeflow:mainfrom
pboyd:bff-openapi-replace
Open

chore(bff): use the latest openapi changes#2634
pboyd wants to merge 1 commit intokubeflow:mainfrom
pboyd:bff-openapi-replace

Conversation

@pboyd
Copy link
Copy Markdown
Member

@pboyd pboyd commented Apr 23, 2026

Description

Use a replace directive in clients/ui/bff for github.com/kubeflow/model-registry/pkg/openapi so it's always on the latest version, and rename it to github.com/kubeflow/hub/pkg/openapi.

Patching changes needed from #1820 that were never brought into the BFF.

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

@Al-Pragliola
Copy link
Copy Markdown
Contributor

Tried it locally, make docker-build-standalone is the only target that failed with:

--> c6289e78d429
[2/4] STEP 7/12: RUN go mod download
go: github.com/kubeflow/model-registry/pkg/openapi@v0.0.0 (replaced by ../../../pkg/openapi): reading /pkg/openapi/go.mod: open /pkg/openapi/go.mod: no such file or directory
Error: building at STEP "RUN go mod download": while running runtime: exit status 1
make: *** [Makefile:85: docker-build-standalone] Error 1

@pboyd pboyd mentioned this pull request Apr 24, 2026
4 tasks
@pboyd
Copy link
Copy Markdown
Member Author

pboyd commented Apr 24, 2026

I need to rebase this and fix the problem @Al-Pragliola reported.

/hold

Use a replace directive in `clients/ui/bff` for `github.com/kubeflow/hub/pkg/openapi` so it's always on the latest version.

Patching changes needed from kubeflow#1820 that were never brought into the BFF.

Signed-off-by: Paul Boyd <paul@pboyd.io>
@pboyd pboyd force-pushed the bff-openapi-replace branch from c364c47 to 597a62a Compare April 24, 2026 15:09
@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from pboyd. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot added size/M and removed size/S labels Apr 24, 2026
@pboyd
Copy link
Copy Markdown
Member Author

pboyd commented Apr 24, 2026

@Al-Pragliola, it's fixed now, thanks.

/unhold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants