Skip to content

fix to collapse consecutive dashes, strip edge dashes, and cap k8s name at 63 chars#2642

Open
Taj010 wants to merge 1 commit intokubeflow:mainfrom
Taj010:job-name-input-handle
Open

fix to collapse consecutive dashes, strip edge dashes, and cap k8s name at 63 chars#2642
Taj010 wants to merge 1 commit intokubeflow:mainfrom
Taj010:job-name-input-handle

Conversation

@Taj010
Copy link
Copy Markdown
Contributor

@Taj010 Taj010 commented Apr 24, 2026

Description

This PR addresses two issues with auto-generated Kubernetes resource names in the model registry UI:

  1. Bad slugs from display namestranslateDisplayNameForK8s now strips leading/trailing dashes, collapses consecutive dashes, and returns a stable gen-<suffix> when the name would otherwise be empty (e.g. punctuation- or dash-only input), matching the main dashboard behavior.

  2. Client vs BFF length mismatch — The register-and-store transfer job field now enforces a 63 character limit (was 253) so validation matches the BFF. Memo deps for autoGeneratedName / isTouched are fixed; the redundant useEffect was removed.

image image

How Has This Been Tested?

Manually tested UI and ran npm run test:unit -- --testPathPattern=K8sNameDescriptionField and npm run test:type-check.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: Taj010 <rsheen003@gmail.com>
@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manaswinidas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot requested review from chambridge and fege April 24, 2026 21:27
@github-actions github-actions Bot added Area/UI and removed size/L labels Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant