fix to collapse consecutive dashes, strip edge dashes, and cap k8s name at 63 chars#2642
Open
Taj010 wants to merge 1 commit intokubeflow:mainfrom
Open
fix to collapse consecutive dashes, strip edge dashes, and cap k8s name at 63 chars#2642Taj010 wants to merge 1 commit intokubeflow:mainfrom
Taj010 wants to merge 1 commit intokubeflow:mainfrom
Conversation
Signed-off-by: Taj010 <rsheen003@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two issues with auto-generated Kubernetes resource names in the model registry UI:
Bad slugs from display names —
translateDisplayNameForK8snow strips leading/trailing dashes, collapses consecutive dashes, and returns a stablegen-<suffix>when the name would otherwise be empty (e.g. punctuation- or dash-only input), matching the main dashboard behavior.Client vs BFF length mismatch — The register-and-store transfer job field now enforces a 63 character limit (was 253) so validation matches the BFF. Memo deps for
autoGeneratedName/isTouchedare fixed; the redundantuseEffectwas removed.How Has This Been Tested?
Manually tested UI and ran
npm run test:unit -- --testPathPattern=K8sNameDescriptionFieldandnpm run test:type-check.Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes