Update Artifacts endpoint with enum security-metrics#2814
Open
ppadti wants to merge 1 commit into
Open
Conversation
Signed-off-by: ppadti <ppadti@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| metricsType: | ||
| type: string | ||
| example: “accuracy-metrics” | ||
| description: An artifact type representing a collection of related metrics, which will either be “performance-metrics” or “accuracy-metrics”. |
Contributor
There was a problem hiding this comment.
small point here, I think is ok to keep the description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to update the artifacts endpoint - mainly updating the enum to include the security-metrics and update the mocks
How Has This Been Tested?
Curl cmd to get only security-metrics:
curl -s -H 'kubeflow-userid: user@example.com' 'http://localhost:4000/api/v1/model_catalog/sources/sample-source/artifacts/repo1/granite-8b-code-instruct?namespace=kubeflow&filterQuery=metricsType.string_value=%22security-metrics%22' | python3 -m json.toolcmd to get all artifacts:
curl -s -H 'kubeflow-userid: user@example.com' 'http://localhost:4000/api/v1/model_catalog/sources/sample-source/artifacts/repo1/granite-8b-code-instruct?namespace=kubeflow' | python3 -m json.toolMerge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes