Skip to content

Change USERNAME env to KUBEFLOW_USERNAME#958

Merged
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
lucferbux:fix-username-dev-mode
Apr 11, 2025
Merged

Change USERNAME env to KUBEFLOW_USERNAME#958
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
lucferbux:fix-username-dev-mode

Conversation

@lucferbux
Copy link
Copy Markdown
Contributor

@lucferbux lucferbux commented Apr 9, 2025

Description

This pull request includes changes to update the environment variable for the username from USERNAME to KUBEFLOW_USERNAME across multiple files in the frontend client. The most important changes include updates to environment variables, documentation, and hooks.

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@lucferbux lucferbux force-pushed the fix-username-dev-mode branch from 5ee2142 to cde6545 Compare April 10, 2025 15:52
@google-oss-prow google-oss-prow Bot added size/S and removed size/XS labels Apr 10, 2025
@lucferbux lucferbux changed the title Add USERNAME variable to environment variables documentation Change USERNAME env to KUBEFLOW_USERNAME Apr 10, 2025
Copy link
Copy Markdown
Contributor

@Al-Pragliola Al-Pragliola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems okay -- Can I only kindly ask to also change the env @ devenv/configs/tiltfiles/frontend.tiltfile at line 85 "USERNAME" => "KUBEFLOW_USERNAME"

… environment variables

Signed-off-by: lucferbux <lferrnan@redhat.com>
@lucferbux lucferbux force-pushed the fix-username-dev-mode branch from cde6545 to 3aab2d3 Compare April 10, 2025 16:43
@lucferbux
Copy link
Copy Markdown
Contributor Author

Everything seems okay -- Can I only kindly ask to also change the env @ devenv/configs/tiltfiles/frontend.tiltfile at line 85 "USERNAME" => "KUBEFLOW_USERNAME"

Ah perfect, I saw that but wasn't sure if it was related, but now I see it's for frontend, thanks a lot @Al-Pragliola

Copy link
Copy Markdown
Contributor

@Al-Pragliola Al-Pragliola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Copy Markdown
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Al-Pragliola, rareddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit b231c27 into kubeflow:main Apr 11, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants