Change USERNAME env to KUBEFLOW_USERNAME#958
Change USERNAME env to KUBEFLOW_USERNAME#958google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
Conversation
5ee2142 to
cde6545
Compare
Al-Pragliola
left a comment
There was a problem hiding this comment.
Everything seems okay -- Can I only kindly ask to also change the env @ devenv/configs/tiltfiles/frontend.tiltfile at line 85 "USERNAME" => "KUBEFLOW_USERNAME"
… environment variables Signed-off-by: lucferbux <lferrnan@redhat.com>
cde6545 to
3aab2d3
Compare
Ah perfect, I saw that but wasn't sure if it was related, but now I see it's for frontend, thanks a lot @Al-Pragliola |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Al-Pragliola, rareddy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This pull request includes changes to update the environment variable for the username from
USERNAMEtoKUBEFLOW_USERNAMEacross multiple files in the frontend client. The most important changes include updates to environment variables, documentation, and hooks.How Has This Been Tested?
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes