Skip to content

Conversation

@ederign
Copy link
Member

@ederign ederign commented Jun 5, 2025

This issue adds @andyatmiami as a member and closes #791 . He has continuously contributed to the Notebooks 2.0 and Dashboard migration.

Provide links to your PRs or other contributions (2-3):

List 2 existing members who are sponsoring your membership:

@ederign @paulovmr

Testing this PR:

============================= test session starts ==============================
platform darwin -- Python 3.12.4, pytest-7.4.4, pluggy-1.0.0
rootdir: /Users/ederign/src/kubeflow/internal-acls/github-orgs
plugins: anyio-4.2.0
collected 1 item

test_org_yaml.py . [100%]

============================== 1 passed in 0.06s ===============================

Copy link
Contributor

@paulovmr paulovmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
/lgtm

@thesuperzapper
Copy link
Member

@andyatmiami has been contributing a lot to Notebook 2.0 in kubeflow/notebooks and the migration of code to kubeflow/dashboard, it will be great to have him as a reviewer in some OWNERS files.

/lgtm

@thesuperzapper
Copy link
Member

@terrytangyuan can you please approve, as @andyatmiami is also from RedHat?

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2e8ac10 into kubeflow:master Jun 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add @andyatmiami as Member of Kubeflow org

4 participants