Skip to content

Conversation

@fege
Copy link
Contributor

@fege fege commented Jul 7, 2025

Related issue: #803

Sponsors: @tarilabs @dbasunag

$ pytest test_org_yaml.py
========================================================================================= test session starts =========================================================================================
platform darwin -- Python 3.12.11, pytest-8.4.1, pluggy-1.6.0
rootdir: /Users/fmosca/Code/internal-acls/github-orgs
collected 1 item                                                                                                                                                                                      

test_org_yaml.py .                                                                                                                                                                              [100%]

========================================================================================== 1 passed in 0.24s =====================================================================

@google-oss-prow
Copy link

Hi @fege. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fege fege force-pushed the fmosca/member branch from f603163 to 12fa421 Compare July 7, 2025 10:31
@dbasunag
Copy link
Contributor

dbasunag commented Jul 7, 2025

/lgtm

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to sponsor this Membership!

Specifically Federico's work has been instrumental to complement the Analysis section for the OpenSSF badge for Model Registry.

/lgtm
/approve

@tarilabs
Copy link
Member

tarilabs commented Jul 7, 2025

@andreyvelich @franciscojavierarceo @juliusvonkohout @terrytangyuan hi, could you kindly approve please

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions @fege!
/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1e1a033 into kubeflow:master Jul 7, 2025
4 checks passed
@fege fege deleted the fmosca/member branch July 8, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants