refactor(labextension): replace Kale toolbar polling with reactive state handling#681
Open
Sayan4496 wants to merge 8 commits intokubeflow:mainfrom
Open
refactor(labextension): replace Kale toolbar polling with reactive state handling#681Sayan4496 wants to merge 8 commits intokubeflow:mainfrom
Sayan4496 wants to merge 8 commits intokubeflow:mainfrom
Conversation
…mands integrated with Kale deployment flow Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
…eployType typing Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
…ate handling Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
Contributor
Author
|
Hi @jesuino, Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the polling mechanism previously used to detect the Kale enable state in the JupyterLab toolbar.
Previously the toolbar relied on a
setIntervalloop to repeatedly check whether Kale was enabled. This approach introduced unnecessary polling in a React-based UI.This change introduces a reactive callback mechanism that notifies the toolbar whenever the Kale state changes.
Changes
setIntervalpolling fromkaleToolbar.tsonKaleStateChangecallback inKubeflowKaleLeftPanelBenefits
Testing
Closes #649