fix(backend): fix inverted condition in podutils and loop bug in rpc/kfp

[ai-naymul]

Fixes #697

cc: @ada333 @jesuino @ederign

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stefanofioravanzo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ai-naymul]

@jesuino @ada333 @ederign this fixes the inverted condition in podutils and a loop bug in rpc/kfp. Happy to address any feedback.

[ederign]

how did you reproduce this bug? can you record a video of it?

[ai-naymul]

how did you reproduce this bug? can you record a video of it?

@ederign sorry for the late reply. Here's the walkthrough: https://www.loom.com/share/c43060725515427ba506d59aa9b25582

Also wanted to flag, while auditing this I noticed _get_pipeline_id in rpc/kfp.py is actually never called anywhere. The live path for upload goes through kfputils.upload_pipeline, which uses the correct version in kfputils. So another option is to just delete it instead of ffixing it. Happy either way, let me know what you prefer.

cc @jesuino @ada333