FIX deprecation warnings in kustomize 5

[juliusvonkohout]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # kubeflow/manifests#2985

@andreyvelich @tenzen-y i just copied over the commit for now

[andreyvelich]

cc @Electronic-Waste @helenxie-bit @tenzen-y @johnugeorge @saileshd1402

[andreyvelich]

Thank you @juliusvonkohout!
/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andreyvelich]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andreyvelich]

@juliusvonkohout Can you sign your commit ?

[juliusvonkohout]

@juliusvonkohout Can you sign your commit ?

I first need to verify that the output stays the same when i run kustomize
/hold

[juliusvonkohout]

$ diff -u old.yaml new.yaml
--- old.yaml    2025-02-10 18:50:39.299136200 +0100
+++ new.yaml    2025-02-10 18:50:19.568703200 +0100
@@ -913,7 +913,7 @@
 kind: MutatingWebhookConfiguration
 metadata:
   annotations:
-    cert-manager.io/inject-ca-from: kubeflow/katib-webhook-cert
+    cert-manager.io/inject-ca-from: KATIB_NAMESPACE_PLACEHOLDER/katib-webhook-cert
   name: katib.kubeflow.org
 webhooks:
 - admissionReviewVersions:
@@ -964,7 +964,7 @@
 kind: ValidatingWebhookConfiguration
 metadata:
   annotations:
-    cert-manager.io/inject-ca-from: kubeflow/katib-webhook-cert
+    cert-manager.io/inject-ca-from: KATIB_NAMESPACE_PLACEHOLDER/katib-webhook-cert
   name: katib.kubeflow.org
 webhooks:
 - admissionReviewVersions:

this is what i have to check

[juliusvonkohout]

@tarekabouzeid can you follow up here?

[mahdikhashan]

@tarekabouzeid can you follow up here?

shall i follow up here?

[andreyvelich]

That would be great @mahdikhashan!

[andreyvelich]

Hi @mahdikhashan, did you followup with this change since we want to release Katib 0.18 in the next 2 weeks ?

[mahdikhashan]

Hi @mahdikhashan, did you followup with this change since we want to release Katib 0.18 in the next 2 weeks ?

thanks for reminding me of this, i'll manage it by then and update my progress.

[andreyvelich]

@mahdikhashan Are we ready to merge it ?

[andreyvelich]

@juliusvonkohout Is it a blocker for Katib 0.18 release, or we can post-pone it ?

[juliusvonkohout]

Lets postpone to Kubeflow 1.10.1. so by a few weeks. @mahdikhashan you can keep the old way in the areas (cert-manager.io/inject-ca-from: kubeflow/katib-webhook-cert) where it is difficult to get diff -u to zero with replacements instead of vars. In the end also 50 % improvement is good and mergeable. Please rebase to master and also sign your first commit. @vikas-saxena02 might help out as well.

[vikas-saxena02]

Yes, I am just doubtful if I understood the problem correctly as I am new to kustomize... i will raise my doubts in today's manifest call. I just updated the agenda for the same

[mahdikhashan]

thank you all, @vikas-saxena02 if you could help us with this, it would be a great help. thanks for your time 🙏

[vikas-saxena02]

@mahdikhashan can you please sign off on your commits otherwise I will have to do a new PR

[vikas-saxena02]

@juliusvonkohout I have raised #2534 as I was unable to fix unisigned commits and figure out reasons for test failures for the test case as the logs are not very descriptive